? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
21 Nov 2015

Issue

Currently it's not that intuitive to find out where those next/prev and other plugin generated output is coming from.

Solution

This PR just adds some simple PHP comments into the layouts which state the triggered event responsible for the generated output.
This should make it easier for frontend devs to figure out where to look.

Testing

Not much you can test here since it only adds PHP comments into the layout. Make sure all com_contact and com_content views are still the same before and after.

avatar Bakual Bakual - open - 21 Nov 2015
avatar Bakual Bakual - change - 21 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2015
Labels Added: ?
avatar infograf768 infograf768 - test_item - 22 Nov 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 22 Nov 2015

I have tested this item :white_check_mark: successfully on 4040f6a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8517.

avatar zero-24
zero-24 - comment - 25 Nov 2015

Maybe this can be implemented only if debug is enabled and not just for com_content? Maybe in the event itself? Or any other generic place? I'm not sure if we hafe a functin thats get called on every plugin event ?

avatar zero-24 zero-24 - change - 25 Nov 2015
Category Components
avatar zero-24 zero-24 - change - 25 Nov 2015
Easy No Yes
avatar Bakual
Bakual - comment - 25 Nov 2015

Maybe this can be implemented only if debug is enabled and not just for com_content?

It's a PHP comment, not a HTML comment. So no output at all. :smile:
It is meant to indicate in the view layout itself where the content from that property is coming from.

avatar alikon
alikon - comment - 25 Nov 2015

tested successfully
it adds more code readabilty so always welcome for me

avatar zero-24 zero-24 - alter_testresult - 25 Nov 2015 - alikon: Tested successfully
avatar zero-24 zero-24 - change - 25 Nov 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 25 Nov 2015

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8517.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Nov 2015
Labels Added: ?
avatar pjwiseman pjwiseman - test_item - 25 Nov 2015 - Tested successfully
avatar pjwiseman
pjwiseman - comment - 25 Nov 2015

I have tested this item :white_check_mark: successfully on 4040f6a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8517.

avatar pjwiseman pjwiseman - test_item - 25 Nov 2015 - Tested successfully
avatar zero-24 zero-24 - change - 26 Nov 2015
Milestone Added:
avatar rdeutz rdeutz - change - 27 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-27 20:27:15
Closed_By rdeutz
avatar rdeutz rdeutz - close - 27 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 27 Nov 2015
avatar rdeutz rdeutz - reference | 6e1ebfa - 27 Nov 15
avatar rdeutz rdeutz - merge - 27 Nov 2015
avatar rdeutz rdeutz - close - 27 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2015
Labels Removed: ?
avatar Bakual Bakual - head_ref_deleted - 27 Nov 2015

Add a Comment

Login with GitHub to post a comment