? ? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
20 Nov 2015

Drop own Mootools script

  • Use jQuery Password Strength Meter for Twitter Bootstrap instead of own Mootols script
  • Affects the field password

Preview

screen shot 2015-11-20 at 16 59 17

Testing

Make sure you use the staging code (all the dev folders should be there)
Apply this patch with patch tester
1.
Edit administrator/components/com_users/models/forms/user.xml and add strengthmeter="true" to the field password
Try to edit one user and type some password
2.
download https://github.com/dgt41/joomla-cms/archive/installationPass.zip
try to install Joomla again…

Updated, so now:

-It uses the latest version of the script (2.0)
-It uses jLayout
-Doesn't use any hardcoded staff (jform_xxx)

avatar dgt41 dgt41 - open - 20 Nov 2015
avatar dgt41 dgt41 - change - 20 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2015
Labels Added: ? ?
avatar dgt41
dgt41 - comment - 20 Nov 2015
avatar dgt41 dgt41 - change - 20 Nov 2015
The description was changed
avatar MAT978 MAT978 - test_item - 20 Nov 2015 - Tested unsuccessfully
avatar MAT978
MAT978 - comment - 20 Nov 2015

I have tested this item :red_circle: unsuccessfully on 6ee8486

First of all, thanks for that as I asked for such a long time (next step the password generator? - run MAT :stuck_out_tongue_closed_eyes: )

Step 1 (create a new user) works fine with 2 notes:
-see the screenshot for the width of the Strength Meter
-IMHO (but an english speaker would help better than me): the red "Your password is too short" could be better as it makes you think you can not save even if it is "just" a warning.
screen shot 2015-11-20 at 15 46 08

Step 2 (new install)
For sure I missed something but I can not reproduce with the Strength Meter...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8513.

avatar dgt41
dgt41 - comment - 20 Nov 2015

@MAT978 The veeeery long progress bar is just some css work that needs to de done in each template. This PR was made initially to indicate the password strength in the installation process, and in that window the progress bar behaves a lot better. So I wouldn’t try to cover all the templates with this PR. Now about the warning: are you asking to just drop the progress bar and leave only the messages?

avatar dgt41 dgt41 - change - 20 Nov 2015
The description was changed
avatar MAT978
MAT978 - comment - 20 Nov 2015

@dgt41 My tarzanBrokenFrenglish let me think that "your password is too short" is imperative for having the ability to register (which is not the case and it's fine like this because, IMHO, it should remain a simple "advice"). I would see something more like: "you should use a stronger password" but for sure, I will leave this job to native English... ;)

avatar dgt41 dgt41 - change - 20 Nov 2015
The description was changed
avatar dgt41
dgt41 - comment - 20 Nov 2015

@MAT978 these are the original strings from https://github.com/ablanco/jquery.pwstrength.bootstrap
But we can change them as there are in the language files of Joomla. So feel free to propose any changes:

JFIELD_PASSWORD_CHARCLASS="Use different character classes"
JFIELD_PASSWORD_LENGTH="Your password is too short"
JFIELD_PASSWORD_NOEMAIL="Do not use your email as your password"
JFIELD_PASSWORD_USERNAME="Your password cannot contain your username"
JFIELD_PASSWORD_WORDREP="Too many repetitions"
JFIELD_PASSWORD_WORDSEQ="Your password contains sequences"
avatar brianteeman
brianteeman - comment - 20 Nov 2015

@dgt41 Great stuff. Only thing is the JFIELD_PASSWORD_LENGTH which sounds like it will be confusing with the existing setting for required password length

avatar wilsonge
wilsonge - comment - 21 Nov 2015

Would it make sense to use the minimum characters parameter in com_users (https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/config.xml#L132-L141) to inject into the JS script here: https://github.com/joomla/joomla-cms/pull/8513/files#diff-92c5eae4ca8022242227f989903d7394R177 ?

Also as in the form field we aren't linking to a username field does it not make sense to disable this option?

avatar Bakual
Bakual - comment - 21 Nov 2015

Also as in the form field we aren't linking to a username field does it not make sense to disable this option?

Would be cool if we optionally allow this feature. Like in the XML you can specify the username field and then it checks that. Not sure how the JS works :)

avatar dgt41
dgt41 - comment - 21 Nov 2015

@Bakual @wilsonge ok done!

avatar Bakual
Bakual - comment - 21 Nov 2015

@dgt41 I think what @wilsonge meant was to retrieve the setting from com_users to determine the minimum length. Which imho makes sense to do.
Obviously, during installation this may not work because the stuff isn't set up yet properly. It should be possible to work around it by using a default value of 4 when in installation application.
Setting it in the XML makes not much sense to me.

avatar dgt41
dgt41 - comment - 21 Nov 2015

@Bakual we can extend the field to incorporate the value from com_users, but I thought that first and foremost this was supposed to be used in the installation process. Anyways I will try to fix that when I'll get back to my pc :)

avatar Bakual
Bakual - comment - 21 Nov 2015

It's a formfield which is available to any extension developer. Thus the attributes should make sense for them as well.
And once this is in, I sure think we should do it for the profile and registration views as well. But keep it to the installation in this PR for now :smile:

When testing I can confirm it works nicely. I like also the checks if you have sequences (eg 123) in the password and using the username triggers an error now as well. So that works nicely.

A small issue I found where I don't have yet found the source is when you enter two different passwords and send the form. The form gets rejected with an error and reloads for obvious reasons. But in that reloaded form the password strength meter doesn't work anymore. If I reload the form using browser reload, it works again.

avatar dgt41
dgt41 - comment - 21 Nov 2015

Make the indicator available also on com_users:
screenshot 2015-11-21 21 23 37

avatar brianteeman
brianteeman - comment - 21 Nov 2015

Does this script actually prevent having username in the password?
If it does not then the message is shouldn't not can't
I

avatar dgt41
dgt41 - comment - 21 Nov 2015

This is only an indicator, the rules for the password are in the validator script and I think you can have the same username and password

avatar Bakual
Bakual - comment - 21 Nov 2015

@dgt41 Have a look what I did here: https://github.com/dgt41/joomla-cms/compare/installationPass...Bakual:PasswordStrength?expand=1
Unfortunately I did it on a newer staging than your PR so it shows some additional commits, but I think you get the idea. :smile:

avatar brianteeman
brianteeman - comment - 21 Nov 2015

If its only an indicator then the string needs changing

avatar dgt41
dgt41 - comment - 21 Nov 2015

@brianteeman I already did that change

avatar Bakual Bakual - change - 22 Nov 2015
Milestone Added:
avatar Bakual
Bakual - comment - 22 Nov 2015

Setting milestone to 3.6.0 since we're already in language freeze mode for installation folder.

avatar zero-24 zero-24 - change - 25 Nov 2015
Category Installation
avatar zero-24 zero-24 - change - 25 Nov 2015
Labels
Easy No Yes
507f1a1 15 Apr 2016 avatar dgt41 map
avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Apr 2016

This PR has received new commits.

CC: @MAT978


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8513.

avatar MDXBilal12 MDXBilal12 - test_item - 19 Apr 2016 - Tested successfully
avatar MDXBilal12
MDXBilal12 - comment - 19 Apr 2016

I have tested this item :white_check_mark: successfully on 0df5416

Test went smoothly. Tested for user name in password as well as password length.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8513.

avatar brianteeman brianteeman - change - 27 Apr 2016
Labels
avatar brianteeman brianteeman - change - 27 Apr 2016
Category Installation Installation Language & Strings
avatar 810
810 - comment - 4 May 2016

I don't see the layout on new user registration.

avatar zero-24 zero-24 - test_item - 7 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on 0df5416

works. We need to clear the cache for the backend. Thanks @wilsonge


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8513.

avatar zero-24 zero-24 - change - 7 May 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 7 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8513.

avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 8 May 2016

Thank you for creating this. It’s been some time since you created this and there are now some merge conflicts that prevent a direct merge. To save time I have created a new Pull Request from your code and am closing this here.

Check #10307.

avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-05-08 11:11:43
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 8 May 2016
avatar wilsonge wilsonge - reference | a50cb9f - 8 May 16
avatar wilsonge wilsonge - reference | 013e82d - 8 May 16
avatar wilsonge wilsonge - reference | c14cd55 - 8 May 16
avatar dgt41 dgt41 - change - 9 May 2016
The description was changed
avatar brianteeman brianteeman - change - 9 May 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 9 May 2016
Milestone Removed:
avatar Kubik-Rubik
Kubik-Rubik - comment - 10 May 2016

@dgt41 Can you please create a new PR and reference to this one. GitHub does not allow me to re-open this PR. I will close my other PR now. Thank you!

Add a Comment

Login with GitHub to post a comment