[#8498] - Fixing list states in JModelList
- Closed
- 26 Jan 2016
- Medium
- Build: staging
- # 8498
- Diff
- Bakual:FixJModelList
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Issue
Current code in JModelList->populateState is wrong for the limit and start case.
limit
In this case, the $value is cleaned properly and saved into $limit. However a bit further down the uncleaned value is stored into the states: $this->setState('list.' . $name, $value);. Obviously the cleaned value should be saved here. Which means we need to overwrite $value with the cleaned value and then also store it into $limit.
start
This case isn't needed at all. Some more lines further down this state is already handled by the following code:
$value = $app->getUserStateFromRequest($this->context . '.limitstart', 'limitstart', 0);
$limitstart = ($limit != 0 ? (floor($value / $limit) * $limit) : 0);
$this->setState('list.start', $limitstart);
Effectively overwriting the value stored in the "start" case. So I simply removed that case.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
I have tested this item 
successfully on e93e6a5
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8498.
I have tested this item successfully on e93e6a5
Pagination works OK
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8498.
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8498.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-26 23:40:00 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
Also added integer filtering to the
limitstartrequesting. It isn't really needed since the value is passed throughfloor()afterwards but it sure doesn't hurt