[#8483] - Proper modal close overrides for tinyMCE
- Closed
- 7 Jan 2016
- Medium
- Build: staging
- Easy Test
- # 8483
- Diff
- dgt41:uselessCode
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This is covered in tinyMCE
Since we moved the XTD buttons in the tinyMCE's toolbar, some overrides for jmodalclose and squeezebox.close functions are required. This is done here
Testing {UPDATED}
To test the functionality of the overrides you will need to comment out and change some lines (temporarily)
So for the case that Mootools are not loaded:
Select ISIS as the template
CASE 1 (No mootools using jModalClose)
Edit an article
Use the xtd buttons to insert an article. (should close the tinymce modal)CASE 2 (No mootools using SqueezeBox.close)
Change line 52 of plugins/editors-xtd/article/article.php toSqueezeBox.close();
Retest (tinymce modal should close)
Now change template to HATHOR
CASE 3 (Mootools present using jModalClose)
Edit an article
Use the xtd buttons to insert an article. (should close the tinymce modal)CASE 4 (Mootools present using SqueezeBox.close)
In the file administrator/components/com_media/views/images/tmpl/default.php change alljModalClose()toSqueezeBox.close()on lines 54-56.
Try inserting an image (through images and links sidebar) and see if the modal closes correctly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Make sure to also check with 3rd party components and plugins.
This code looks like some B/C code which allows to close Mootools modals using JModal.close.
The modal method also isn't specific to the editor plugins and TinyMCE. It is used for any modals by any extension. So please don't only test with the core editor buttons.
Ohh crap
Ah, makes more sense now indeed 
The changes in the pagebreak plugin looks more like it is only codestyle, with a bit visual change coming from changing 'btn-primary' to 'btn-success pull-right'. I'm not sure what the purpose is there. At least it looks unrelated to the PR and I would actually like to keep PRs on a single topic.
So I'm not sure if that change ended up here accidently.
@Bakual the script part is indeed just cs, but the addition of the blank line at the top was reported before as bad rendering for that modal. Also the change of classes for the button is just for consistency. These are really easy fixes so I thought to throw them here instead of opening yet another PR
I did a clean install and now the modal windows are closing with isis, not with hathor.
Side note: I could not reproduce the problem with the page break modal with isis, but with hathor. I also wanted to test a 3rd party extension but I found a fundamental problem there. To clarify that I invited them to test there extension with the current staging branch.
I will do some more test when I have time available.
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | Libraries |
Firefox. Macintosh
Before patch:
I do not have the general issue here. Modals close OK (some need to click the Insert Button which is fine), except when using Hathor and com_messages Recipient where one has to Close the modal to get the user name into the field after clicking on that name.
After patch:
The issue is solved with Hathor and com_messages. Choosing a recipient closes the modal.
BUT Hathor gets a new issue:
choosing an article in the modal when using the xtd in Hathor does not close anymore the modal.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-30 00:41:28 |
| Closed_By | ⇒ | dgt41 |
| Status | Closed | ⇒ | Pending |
@infograf768 can you reopen this one? I closed it by mistake...
| Status | Closed | ⇒ | Pending |
| Closed_Date | 2015-12-30 00:41:27 | ⇒ | |
| Closed_By | dgt41 | ⇒ |
Re-opened
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8483.
Set to "open" on behalf of @infograf768 by The JTracker Application at issues.joomla.org/joomla-cms/8483
Calling for testers as this is a release blocker
@waader @anibalsanchez @infograf768 @andrepereiradasilva
| Title |
|
||||||
| Title |
|
||||||
I have tested this item 
unsuccessfully on 2e20a49
After commenting the lines, the article is inserted in the text but the modal is not closed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8483.
@anibalsanchez You did also change line 52 of plugins/editors-xtd/article/article.php jModalClose(); to SqueezeBox.close(); ?
I have tested this item 
successfully on 2e20a49
Ups, I read only the part about commenting! It works perfectly fine :-D
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8483.
@anibalsanchez sorry about the poor instructions, I've updated them to be more clear and easy steps to follow! Thanks for texting!
I have tested this item successfully on 2e20a49
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8483.
| Status | Pending | ⇒ | Ready to Commit |
This should go into 3.5.0.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8483.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-07 14:32:20 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
Please add milestone.
| Milestone |
Added: |
||
I could not see any difference after applying the patch. When I select a module or article link the modal window stays open.
When inserting a page break you can see another odd behavior which has nothing to do with this patch. I type in some text in the "Page Title" field and the "Table of Contents Alias" field then I hit the "Insert Page Break" Button. Next the CPanel get loaded within the modal window.