User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Status | Pending | ⇒ | Ready to Commit |
Milestone |
Added: |
Labels |
Added:
?
|
Not sure if that is right. If you have SEF on then start is used and when off then limitstart. So I think we need to test that, wouldn't merge that on review
Current code is wrong for sure. Doesn't make sense to take the "start" value and save it into the $limit variable.
limitstart
is a proxy to start
as far as I know. The router does rewrite that somewhere if I remember right. If not, we would need an additionally case limitstart which could be added to the start one. But it would be a different issue unrelated to this PR.
But if we don't set $limit it is always 0 so $limitstart is also 0, doesn't makes sense either.
But if we don't set $limit it is always 0 so $limitstart is also 0, doesn't makes sense either.
But we set $limit, this fix set $start too. For what reason we set $start to $limit ("warm" vs "soft")?
For example: we have list.limit = 20 and list.start = 0. We set in url ?start=20.
Not fixed code must do this:
list.start = 0 (because we don't assign list.start)
list.limit = 20 (because we assign start to $limit)
Finally we have first 20 records instead of second 20.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-19 11:19:50 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
Setting RTC based on review.