?
avatar sakattack
sakattack
17 Nov 2015

Ok, so I came acrross a bug that occurs on custom html modules (could be happening to others as well), which results in possible loss of all of module's made choices.

Steps to reproduce the issue

  1. create a custom html module and add some class suffixes to it, save it and close it.

  2. Start the creation of a new custom html module but do not add any class suffixes to it and do not save it.

  3. While at the creation screen of the new custom html module, open module manager on a new tab, and then open the custom html module you created on the first step. This module will now have NO class suffixes (or any other choice it may have had). (The suffixes are in the database but are not displayed, if you make the mistake to save the module, they will be lost)

System information (as much as possible)

joomla 3.4.5

The problem has been happening for all joomla 3+ versions

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar sakattack sakattack - open - 17 Nov 2015
avatar sakattack sakattack - change - 17 Nov 2015
The description was changed
avatar sakattack sakattack - change - 17 Nov 2015
Title
Module loses chosen options
Module loses chosen options
avatar brianteeman brianteeman - change - 18 Nov 2015
Status New Confirmed
avatar brianteeman
brianteeman - comment - 18 Nov 2015

I can confirm this following the steps above


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8464.

avatar bertmert
bertmert - comment - 19 Nov 2015

I can confirm this for ALL advanced options.
Not for other ones in other tabs.

And it's independent from the module type you open with New

avatar bertmert
bertmert - comment - 19 Nov 2015

It looks like these lines are overriding

$data->params

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_modules/models/module.php#L606-L611

Surrounding them with

if (empty($data->params))
{
.... lines 606-611
}

fixed the issue but I'm not shure if it should be fixed earlier when userState is written, maybe with an additional module id.
So, no PR.
Needs some help/comment from a "wise guy".

avatar zero-24 zero-24 - change - 25 Nov 2015
Category Administration
avatar bertmert bertmert - reference | 8e8157d - 28 Nov 15
avatar bertmert
bertmert - comment - 28 Nov 2015

Please test PR #8557

avatar infograf768 infograf768 - change - 29 Nov 2015
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2015-11-29 08:11:51
Closed_By infograf768
avatar joomla-cms-bot joomla-cms-bot - close - 29 Nov 2015
avatar infograf768
infograf768 - comment - 29 Nov 2015

Closing as we have a patch #8557


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8464.

avatar infograf768
infograf768 - comment - 29 Nov 2015

Add a Comment

Login with GitHub to post a comment