Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8458] - Fix: Post Install Messages sort order

? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
17 Nov 2015

Issue

The Messages are displayed in ascending ID which means that the oldest ones are at the top. I know there are only 3 right now but it makes more sense to me that the newest message is always at the top (ORDER BY postinstall_message_id DESC )

I did try to fix this myself but only managed to ADD it to the ORDER by not change it.

Fixing: #8382

How to test

  • Install staging
  • see there are postinstall messages
  • see that the 3.2.0 one is on the top
  • apply this patch using com_patchtester
  • see there are now the newest on the top.

Thanks @brianteeman

avatar zero-24 zero-24 - open - 17 Nov 2015
avatar zero-24 zero-24 - change - 17 Nov 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2015
Labels Added: ?
avatar brianteeman brianteeman - test_item - 17 Nov 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Nov 2015

I have tested this item :white_check_mark: successfully on 3bec4da

Thanks - works perfectly

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8458.

avatar zero-24 zero-24 - change - 17 Nov 2015
Category ⇒ Administration UI/UX
avatar zero-24 zero-24 - change - 17 Nov 2015
Easy No ⇒ Yes
avatar waader waader - test_item - 17 Nov 2015 - Tested successfully
avatar waader
waader - comment - 17 Nov 2015

I have tested this item :white_check_mark: successfully on 3bec4da

Thanks zero-24!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8458.

avatar zero-24 zero-24 - change - 17 Nov 2015
Milestone Added:
Status Pending ⇒ Ready to Commit
avatar zero-24 zero-24 - change - 17 Nov 2015
Milestone Added:
avatar zero-24
zero-24 - comment - 17 Nov 2015

Thanks. RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8458.

avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2015
Labels Added: ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 17 Nov 2015

This PR has received new commits.

CC: @brianteeman, @waader

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8458.

avatar zero-24
zero-24 - comment - 17 Nov 2015

@brianteeman @waader I have just got the tip by @roland-d to do this with just one line so it is much cleaner and don't hack the state variable. Can you test again? Thanks.

avatar zero-24 zero-24 - change - 17 Nov 2015
Status Ready to Commit ⇒ Pending
Labels
avatar zero-24 zero-24 - change - 17 Nov 2015
Labels Removed: ?
avatar brianteeman brianteeman - test_item - 17 Nov 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Nov 2015

I have tested this item :white_check_mark: successfully on 7ff2882

Tested again - still works

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8458.

avatar waader waader - test_item - 17 Nov 2015 - Tested successfully
avatar waader
waader - comment - 17 Nov 2015

I have tested this item :white_check_mark: successfully on 7ff2882

Works!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8458.

avatar roland-d roland-d - change - 17 Nov 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2015
Labels Removed: ?
avatar roland-d roland-d - change - 17 Nov 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-11-17 18:02:07
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 17 Nov 2015
avatar roland-d roland-d - reference | 5e96666 - 17 Nov 15
avatar roland-d roland-d - merge - 17 Nov 2015
avatar roland-d roland-d - close - 17 Nov 2015
avatar zero-24
zero-24 - comment - 17 Nov 2015

Thanks :+1:

avatar zero-24 zero-24 - head_ref_deleted - 17 Nov 2015

Add a Comment

Login with GitHub to post a comment