User tests: Successful: Unsuccessful:
Reverts joomla/joomla-cms#7782
We have to revert the change because a protected function _fromObject and _sortObject are removed by the change.
Here is why. Someone could have extend the class and use one of the removed functions. It is a bad idea but someone could and this change isn't B/C.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Why? there a 4 function changes. 2 of them are b/c 2 aren't. so just revert the stuff that is not b/c.
@wilsonge @rdeutz Should I PR again to revert just those methods with B/C issues?
I mean to revert only fromObject
, _fromObject
, sortObjects
, _sortObjects
. And leave toInteger
, pivot
, arrayUnique
methods as it is now.
If we can update ArrayHelper
form the https://github.com/joomla-framework/utilities, then it would still be possible to minimize the methods fromObject
, _fromObject
. Otherwise it is important to revert these two.
We're not going to change the framework. We'll just need to override those methods at the CMS levels. But yes - we'll need to keep the _fromObject
and _sortObjects
methods
I would prefer to revert this one and have a new PR for the changes that are not a B/C break, could you do a PR @izharaazmi ?
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-18 19:03:55 |
Closed_By | ⇒ | roland-d |
Milestone |
Added: |
At least keep the changes in
toInteger
andarrayUnique
they are fine and have no b/c implications