[#8449] - JBrowser Opera 15+ detection
- Closed
- 17 Apr 2016
- Medium
- Build: staging
- Easy Test
- # 8449
- Diff
- sergey-zero:staging
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Opera 15 + browsers detection in JBrowser.
How to test
You can use this code snippet for test of detection
jimport('joomla.environment.browser');
$browser = JBrowser::getInstance();
$browserType = $browser->getBrowser();
$browserVersion = $browser->getMajor();
var_dump($browserType, $browserVersion);
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
| Easy | No | ⇒ | Yes |
I have tested this item 
successfully on a66d92a
Tested on UKFast hosting:
PHP: 5.4.45
MySQL: 5.5.37
Apache webserver
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8449.
I have tested this item successfully on a66d92a
Tested on Namesco hosting:
PHP: 5.3.29
MySQL: 5.5.44-37.3-log
Apache webserver
Before patch got chrome 47 after patch, got opera 34 (correctly)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8449.
@sergey-zero can you please merge the PR by @piotr-cz Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8449.
@roland-d sergey-zero#1 is my PR 
@sergey-zero Please merge mentioned PR
Tested with:
Opera 36
Linux 15.10
Php 5.6.20
Success!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8449.
I have tested this item successfully on a66d92a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8449.
@sergey-zero Can you please fix the failed test. The error is:
FILE: ...travis/build/joomla/joomla-cms/libraries/joomla/environment/browser.php
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
248 | ERROR | Please start your comment with a capital letter; found "// for
| | opera 15+"
Thank you.
@roland-d PR sergey-zero#1 correcting this error is waiting for approval by @sergey-zero from 18 November 2015. If you do not have nothing against I will open a new PR without this error.
Yes please create a new pr
@brianteeman new PR is #9949
@digitalgarage @Bodge-IT @henkrijneveld Please test #9949
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-17 00:18:58 |
| Closed_By | ⇒ | brianteeman |
There is one more browser detection library shipped with joomla, JApplicationWebClient.
Adequate fix is here: joomla-framework/application#53
BTW: test fail because Please start your comment with a capital letter; found "// for opera 15+"