? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
15 Nov 2015

Description

Problem: Mod languages uses an absolute URI in the ative language flag image link and site root relative URI for the other languages.

This patch converts the absolute URI in the ative language URI to site root relative URI.

How to test

After the patch the ative language URI in mod languages flag image link should be relative to site root.

B/C

None.

avatar andrepereiradasilva andrepereiradasilva - open - 15 Nov 2015
avatar andrepereiradasilva andrepereiradasilva - change - 15 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Nov 2015
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Nov 2015

Don't know why travis failed in php 7 tests.
A lot of permisisons denied.

avatar zero-24
zero-24 - comment - 15 Nov 2015

@andrepereiradasilva

It don't look like realted to your patch. And it is not just you. Maybe Travis has problems with PHP 7 Builds ;)

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Nov 2015

Ok. Let's wait for a more healthy travis.

avatar infograf768
infograf768 - comment - 15 Nov 2015

Tested and I see no issue with this patch.
There was no issue before either.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Nov 2015

@infograf768 yes that was no issue earlier, is just a question of normalization. If the other URI are site root relative the ative language URI should be too.

avatar richard67
richard67 - comment - 16 Nov 2015

From my point of view, the active language link is useless anyway because it always points to the current page. If someone on a smart phone has thick fingers, he well be happy when there is one useless link less he might accidently tip on while trying to tip on the one beside. On my website I have therefore made an overrride for the language switcher module, which shows for the current language the flag or text as a picture or a text only but not as a link, and with CSS style I give it a different appearance so everybody can see this is the current language.

So I think this PR here deals with making something which is useless anyway to be formally more correct.

@infograf768 What do you think about my opinion? You can have a look on my website to see how it looks like.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8440.

avatar richard67
richard67 - comment - 16 Nov 2015

P.S.: @infograf768 If you like it, I can make a PR for this as a suggestion for improvement.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8440.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Nov 2015

@richard67 this PR is only to correct that minor normalization issue.
If you want to make other changes please open a PR and i will close this one if yours is merged.

By the way i think the flag transperency from an usability point should be inverted (transparency not selected, no transparency selected). The selected items normally are highlited (ex: bold, other color, other background color, etc), see your menu for instance.

avatar richard67
richard67 - comment - 16 Nov 2015

@andrepereiradasilva Right, my idea is another issue than this PR, it is just related. I did not want to mess up your PR, sorry. Just was curious on what @infograf768 thinks about it. Regarding the transparency: I tried both variants, the one I have now with the transparent active language flag I liked more because the pale flag makes it look a bit like a deactivated control, which fits to the fact that there is no link anymore. But in case somebody wanted this functionality in Joomla and I would make a PR for that (independently from yours at a later point of time) I could maybe find a better way of styling.

Ah, and I remembered the active language link not right because I don't use it. I think now it does not point to the current page but to the home page. But this does not make this link more useful.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8440.

avatar infograf768
infograf768 - comment - 17 Nov 2015

@richard67
The active language link does point to the current page and not Home.
I am not sure we need to take off the link.
We do have a parameter to not display the active language and I guess it is enough.
In any case, this can be overriden if desired, as you did.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Nov 2015

There is no travis problem.
@zero-24 how can we retest in travis?

avatar zero-24
zero-24 - comment - 22 Nov 2015

@andrepereiradasilva you can't do this by your self but i have just restarted it ;) It is the old error on PHP 7 Builds ;)

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Nov 2015

thanks @zero-24

avatar infograf768 infograf768 - test_item - 23 Nov 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 23 Nov 2015

I have tested this item :white_check_mark: successfully on b38a25c

Totally B/C


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8440.

avatar zero-24 zero-24 - change - 25 Nov 2015
Category Modules
avatar zero-24 zero-24 - change - 25 Nov 2015
Easy No Yes
avatar anibalsanchez anibalsanchez - test_item - 27 Dec 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 27 Dec 2015

I have tested this item :white_check_mark: successfully on b38a25c

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8440.

avatar infograf768 infograf768 - change - 28 Dec 2015
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 28 Dec 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8440.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 6 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Removed:
avatar wilsonge wilsonge - change - 17 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-17 15:39:49
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 17 Jan 2016
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 17 Jan 2016

Add a Comment

Login with GitHub to post a comment