?
avatar shamsbd71
shamsbd71
14 Nov 2015

Steps to reproduce the issue

Install new joomla 3.5 beta with sample data. go to article manager and edit any article.
click on module button on new tinyMCE editor. see top search option for module style

Expected result

not sure what is this for but i tried with some search type like: xhtml, html, raw but nothing worked and seems its not working at all

Actual result

it should be properly placed. not its looking very bad and not enough description to understand.

System information (as much as possible)

Windows 10 and WAMP with php 5.5

screen shot 2015-11-14 at 01 07 51

avatar shamsbd71 shamsbd71 - open - 14 Nov 2015
avatar dgt41
dgt41 - comment - 14 Nov 2015

This is just an input to append a specific style for the module. It won’t return anything, you need to know the available module styles (template dependent). If you think this is confusing please suggest some other label that will make this easier to grab.

avatar brianteeman
brianteeman - comment - 14 Nov 2015

This view does seem odd to me. The styling is different to module manager
(nicer).

As for adding the style I am not sure I see the need for this at all here
as you would normally define this in the module itself. (Does it replace
existing styles?)
On 14 Nov 2015 10:34 am, "Dimitri Grammatikogianni" <
notifications@github.com> wrote:

This is just an input to append a specific style for the module. It won’t
return anything, you need to know the available module styles (template
dependent). If you think this is confusing please suggest some other label
that will make this easier to grab.


Reply to this email directly or view it on GitHub
#8428 (comment).

avatar brianteeman
brianteeman - comment - 14 Nov 2015

I guess I am saying what is the use case for adding an additional style
option here.
On 14 Nov 2015 10:39 am, "Brian Teeman" brian@teeman.net wrote:

This view does seem odd to me. The styling is different to module manager
(nicer).

As for adding the style I am not sure I see the need for this at all here
as you would normally define this in the module itself. (Does it replace
existing styles?)
On 14 Nov 2015 10:34 am, "Dimitri Grammatikogianni" <
notifications@github.com> wrote:

This is just an input to append a specific style for the module. It won’t
return anything, you need to know the available module styles (template
dependent). If you think this is confusing please suggest some other label
that will make this easier to grab.


Reply to this email directly or view it on GitHub
#8428 (comment)
.

avatar dgt41
dgt41 - comment - 14 Nov 2015

Setting the style here will override the saved module style, maybe this can be done with a button named advanced which will reveal the input. Anyhow, most of the users won’t use this option, I think

avatar brianteeman
brianteeman - comment - 14 Nov 2015

And that's the problem. It is the very first thing on the screen which
creates the impression it is important when as you suggest it will be
rarely used (have to say I can't think of a use case)
On 14 Nov 2015 11:36 am, "Dimitri Grammatikogianni" <
notifications@github.com> wrote:

Setting the style here will override the saved module style, maybe this
can be done with a button named advanced which will reveal the input.
Anyhow, most of the users won’t use this option, I think


Reply to this email directly or view it on GitHub
#8428 (comment).

avatar shamsbd71
shamsbd71 - comment - 14 Nov 2015

oh! i got that finally!!! what is this for :)
i agree with @brianteeman it should be somewhere else or maybe we need to think a bit different way.
maybe something like this:
module-popup

avatar Bakual
Bakual - comment - 14 Nov 2015

it will be used (have to say I can't think of a use case)

As for the usecase. Since here you load the module into an article, there isn't really a module style applied to it. I use this option often (eg by using the "well" style) so the module has a visual "border" (lack of knowing better word)

avatar brianteeman
brianteeman - comment - 14 Nov 2015

What is stopping you putting "well" in the module class suffix in the
normal way?
On 14 Nov 2015 1:53 pm, "Thomas Hunziker" notifications@github.com wrote:

it will be used (have to say I can't think of a use case)

As for the usecase. Since here you load the module into an article, there
isn't really a module style applied to it. I use this option often (eg by
using the "well" style) so the module has a visual "border" (lack of
knowing better word)


Reply to this email directly or view it on GitHub
#8428 (comment).

avatar Bakual
Bakual - comment - 14 Nov 2015

That was only a (bad) example, depending on the template there are other styles where you can't achieve the same effect by just using a suffix. Like when they use a unique HTML structure around it.

avatar brianteeman
brianteeman - comment - 14 Nov 2015

Whats a good example then? :)

Either way it doesnt address the UI issue

And that's the problem. It is the very first thing on the screen which
creates the impression it is important when as you suggest it will be
rarely used (have to say I can't think of a use case)

On 14 November 2015 at 15:03, Thomas Hunziker notifications@github.com
wrote:

That was only a (bad) example, depending on the template there are other
styles where you can't achieve the same effect by just using a suffix. Like
when they use a unique HTML structure around it.


Reply to this email directly or view it on GitHub
#8428 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 15 Nov 2015

How about moving this block at the end of that page?

avatar shamsbd71
shamsbd71 - comment - 17 Nov 2015

Hey, i got my final suggestion:
** Remove this option complete to add style **

because when i select a module to insert with short-code, its already been defined in modules details settings, when i select it to load in article or anywhere it should be same as its defined in module. if i need raw output, i should change the module settings.

and to load module position : it should be at top like the previous attached pic, so to find any position i dont need to see the pagination and or search.

i think this is very simple :)

avatar shamsbd71
shamsbd71 - comment - 17 Nov 2015

if you all agree, i can create a pull request with removing that option ?

avatar brianteeman
brianteeman - comment - 10 Mar 2016

Personally thats exactly what I would submit a a PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8428.

avatar brianteeman brianteeman - change - 10 May 2016
Status New Confirmed
avatar brianteeman
brianteeman - comment - 4 Aug 2016

I created a PR for testing so closing this here see #11436

avatar brianteeman brianteeman - change - 4 Aug 2016
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2016-08-04 09:48:24
Closed_By brianteeman
avatar brianteeman brianteeman - close - 4 Aug 2016

Add a Comment

Login with GitHub to post a comment