Feeling Lucky
?
[#8420] - editor button->onclick, SyntaxError: expected expression, got ','
- Closed
- 14 Nov 2015
- Medium
- Build: staging
- # 8420
- Diff
- anibalsanchez:patch-1
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
tinymce is concatenating button callback with , and it generates the SyntaxError.
It is fixed removing ,
To test it, a callback can be added to any of the current editors-xtd plugins. For instance, in plugins/editors-xtd/image/image.php, line 62:
$button->onclick = 'alert("test")';
When the patch is applied, there is no console error, editor loads fine and when you click on the button it shows 'test'
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
dgt41
- comment
- 14 Nov 2015
I have tested this item 
successfully on b8c6a12
Good catch, thanks @anibalsanchez
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8420.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 14 Nov 2015
| Labels |
Added:
?
|
||
Bakual
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-14 08:29:28 |
| Closed_By | ⇒ | Bakual |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on b8c6a12
Before applying the patch I see the JavaScript error, after applying the patch the error is gone and the code is outlined nicely.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8420.