? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
12 Nov 2015

test info

see #8362

before patch

unable to show explain
before

after patch

able to show explain
after

avatar alikon alikon - open - 12 Nov 2015
avatar alikon alikon - change - 12 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Nov 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 12 Nov 2015
Milestone Added:
avatar mbabker
mbabker - comment - 12 Nov 2015

I don't see how this can work. You're disconnecting the database connection in the debug plugin's constructor, which is very early in the application stack. You need to call disconnect() immediately before starting to grab the log data. As is, you'll get log data for any query run before the debug plugin is instantiated (so anything before the onAfterInitialise trigger is called).

2d9ebef 12 Nov 2015 avatar alikon ops
avatar alikon
alikon - comment - 12 Nov 2015

:innocent: cut&paste in the wrong place

avatar infograf768
infograf768 - comment - 13 Nov 2015

I now get Explain and Profile with this PR.
@mbabker
Is the code OK now?

avatar shur
shur - comment - 13 Nov 2015

Explain started working.
Thanks @alikon

avatar waader waader - test_item - 15 Nov 2015 - Tested successfully
avatar waader
waader - comment - 15 Nov 2015

I have tested this item :white_check_mark: successfully on 51d5ede

Thanks alikon!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8404.

avatar zero-24 zero-24 - change - 15 Nov 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 15 Nov 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8404.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Nov 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 16 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-16 20:44:24
Closed_By rdeutz
avatar rdeutz rdeutz - close - 16 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 16 Nov 2015
avatar rdeutz rdeutz - reference | a7026fc - 16 Nov 15
avatar rdeutz rdeutz - merge - 16 Nov 2015
avatar rdeutz rdeutz - close - 16 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment