[#8399] - Move component message to system-message-container
- Closed
- 9 Apr 2016
- Medium
- Build: staging
- Easy Test
- # 8399
- Diff
- n9iels:component-messages
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
With the move of all the filter from the left sidebar to joomla.serachtools some component messages has a small layout issue. The messages are stick to the serachtools, without padding.
This PR moves all messages like "Enable this plugin", "This option is enabled" to a JFactory::getApplication()->enqueueMessage(). So they will be displayed above the serachtools. All messages like "There are no item available` stay below the searchtools.
Test instructions
Compare the following screenshots
1) Go to Components -> Smart Search
Before the patch:
After the patch:
2) Go to Extensions -> Manage -> Database
Before the patch:
After the patch:
3) Go to Extensions -> Install
Before patch:
After patch:
4) Go to Extensions -> update
Before patch:
After patch:
5) Go to Components -> Redirect
Before the patch:
After the patch:
6) Go to components -> Search
Before the patch:
After the patch:
7) Disable the plugin, and enable/disable the Gathering statistics options. Confirm the messages are the same before and after the patch
Note
This is a redo of #8282, someting went wrong with solving merge conflict over there
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
zero-24
- | Milestone |
Added: |
||
| Category | ⇒ | UI/UX |
| Easy | No | ⇒ | Yes |
roland-d
- | Milestone |
Added: |
||
| Milestone |
Removed: |
||
+1 can be merged, same results as other pr.
I have tested this item 
successfully on dc4c0b2
Followed test instructions and tested ok
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8399.
Is it possible to set this PR on RTC? Because it is a copy of a PR which was allready tested succesful...
I have tested this item successfully on dc4c0b2
It works OK
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8399.
| Status | Pending | ⇒ | Ready to Commit |
Marking RTC (not sure why it has a 3.6 milestone)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8399.
| Labels |
Added:
?
|
||
This PR has received new commits.
CC: @andrepereiradasilva, @anibalsanchez
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8399.
@brianteeman thanks :)
I solved the merge conflict, so it is completely RTC
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-09 14:14:40 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I guess that, as long as it is not deleted in script.php, it is no use indeed for new installs.