? Success

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
12 Nov 2015

This is one from the series of edits in which we try to remove usage of deprecated JArrayHelper from the entire Joomla core system. Taking one extension/library at a time for easy tests.

avatar izharaazmi izharaazmi - open - 12 Nov 2015
avatar izharaazmi izharaazmi - change - 12 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Nov 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 25 Nov 2015
Category Components
avatar sovainfo
sovainfo - comment - 22 May 2016

Any reason you are not using: use Joomla\Utilities\ArrayHelper; with ArrayHelper::.... ?
That is what is currently used in core code!

avatar izharaazmi
izharaazmi - comment - 22 May 2016

Since it is a single usage in this file, I avoid import namespace in such case as a habit. Usually I import if and only if two or more usages occur.

avatar conconnl
conconnl - comment - 27 Jun 2016

How can we test this?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8394.

avatar izharaazmi
izharaazmi - comment - 27 Jun 2016

I see this has already been fixed and merged with #9121 (code). It is now already a part of J3.5

I wish there has been some automated method to detect pending PR per file basis. This could save lot of work duplicacy.

I'll now close this one. Thanks everybody.

avatar izharaazmi izharaazmi - change - 27 Jun 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-06-27 06:31:33
Closed_By izharaazmi
avatar izharaazmi izharaazmi - close - 27 Jun 2016

Add a Comment

Login with GitHub to post a comment