[#8391] - Update application.xml required fields
- Closed
- 16 Nov 2015
- Medium
- Build: staging
- # 8391
- Diff
- brianteeman:required-config
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
In Global Configuration we have several fields that are marked as required in the xml and as a result have a * next to the label.
When they are a select field this is useless as there is always a value eg Help Server and there is no way to ever not have a value.
There appears to be no real logic in which fields are marked as required. For example Mailer type is required but Database type is not required - of course it is require but its a select that always has a value.
This PR removes the required=true for all fields where there is no way for the user ever to have no data
This PR also removes the few cases where required=false is set. (We should set it for all or none)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
technically prefix is not required as it has a default value of jos_
PR welcome
On 12 November 2015 at 12:19, infograf768 notifications@github.com wrote:
I guess you could at the same time make required=true for some database
settings
host, username, name, prefix—
Reply to this email directly or view it on GitHub
#8391 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
You have a PR
brianteeman#1
Travis error unrelated to this PR
I have tested this item 
successfully on 410e329
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8391.
I have tested this item successfully on 410e329
Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8391.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8391.
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-16 20:36:03 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I guess you could at the same time make required=true for some database settings
host, username, name, prefix