[#8387] - Fix id attribute generation to be unique within the HTML document
- Closed
- 17 Jan 2016
- Medium
- Build: staging
- Easy Test
- # 8387
- Diff
- matrikular:patch-4
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This pr fixes the generation of the id attribute for each fieldset by adding a group name prefix similar to the class.
Reference:
http://www.w3.org/TR/html401/struct/global.html#adef-id
Note:
If I'm not mistaken, the class "should be" the same for all fieldsets. I did not remove the group to keep it bc.
Furthermore I've reformatted some code blocks to match the code sniffer rules and added a more strict check to the legend rendering method of each fieldset.
Background:
If one overrides a translatable string with an empty string, the legend tag would be rendered without a text which could lead to a messed up styling of the form in general.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Administration |
| Easy | No | ⇒ | Yes |
I have tested this item 
successfully on 9db9d13
Tested OK with users-profile-custom-profile
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8387.
| Status | Pending | ⇒ | Ready to Commit |
Thanks for testing RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8387.
| Labels |
Added:
?
|
||
rdeutz
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-17 01:19:37 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Merged - thanks :)
I have tested this item
successfully on 9db9d13
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8387.