[#8380] - Regression: jModalClose is unavailable if no mootools
- Closed
- 12 Nov 2015
- Medium
- Build: staging
- # 8380
- Diff
- dgt41:tinyBTNS
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Fixes #8378
Testing
Set tinyMCE as you editor
try the button insert article, the link should be inserted and the modal should close
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Milestone |
Added: |
||
While this fixes the issue for the article button, it doesn't fix the underlying issue.
All 3rd party plugins with similar code will still be broken, and especially closing the active modal is something many (most?) plugins use in this case.
Unfortunately it looks like the move to use Bootstrap modals instead of SqueezeBox isn' that easy. If we can't proxy the old closing method to close the Bootstrap modal, then I'm afraid that PR isn't B/C and imho needs to be reverted.
Can you fix the CS issues Travis complains about?
Also I see some commented out code lines. I guess those are leftovers?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-12 12:26:24 |
| Closed_By | ⇒ | dgt41 |
| Milestone |
Removed: |
||
Just a remark the broken part is the undefined jModalClose function, the rest is just moving js to a part where can be overridden...