Feeling Lucky
?
[#8375] - don't load finder label instead of make it invisible
User tests: Successful: Unsuccessful:
This PR make sure the label of the mod_finder don't load. Before it was only invisible via the class element-invisible. But if you're template.css don't contain this class, the label won't hide.
Test instructions
1) Make a mod_finder module and hide the label via the parameter "Search Field Label"
2) Go to the front-end, inspect the source (right click -> inspect element), and notice the label is only invisible:
<label for="mod-finder-searchword" class="finder">Search</label>
3) Apply the patch, and notice the label is not load any more.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- comment
- 11 Nov 2015
For reference http://webaim.org/techniques/css/invisiblecontent/
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-11 14:28:21 |
| Closed_By | ⇒ | wilsonge |
This is the wrong thing to do. The reason the label is invisible rather than not loaded is for accessibility. Having the label present but hidden allows for screen-readers to help the user with these inputs.