? Success
Referenced as Related to: # 8378 # 8427

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
10 Nov 2015

DRY

Few lines are repeated on the 3 different modes. We don’t have to…

Also instead of using tinyMCE.activeEditor we target exactly the editor we want.

Testing

Use tinyMCE as your editor. Try all different modes (simple, advanced, extended).

avatar dgt41 dgt41 - open - 10 Nov 2015
avatar dgt41 dgt41 - change - 10 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 10 Nov 2015
Milestone Added:
avatar Fedik
Fedik - comment - 12 Nov 2015

I got Uncaught TypeError: window.parent.jInsertEditorText is not a function when try select something in the modal (from xtd buttons)
seems public function onGetInsertMethod($name) never called .. strange

other things seems work fine :smile:

avatar dgt41
dgt41 - comment - 13 Nov 2015

@Fedik normality restored...

avatar Fedik
Fedik - comment - 13 Nov 2015

one more:
When click on "Read More" button Uncaught TypeError: Cannot read property 'getContent' of null

avatar roland-d
roland-d - comment - 13 Nov 2015

Using the extension sliders, I get a different popup clicking on the button. This is in J 3.4.5:
image

and this is in 3.5.0-dev:
image

@Fedik mentioned in #8378 this is due to Mootools using eval for the code "{handler: 'iframe', size: {x:window.getSize().x-100, y: window.getSize().y-100}}" perhaps we can do the same?

avatar roland-d
roland-d - comment - 13 Nov 2015

We are in need of some padding above the Page title field:
image

Since the article modal needs some padding as well, perhaps we need to a padding all around of let's say10px.

7caeab0 16 Nov 2015 avatar dgt41 cs
51123a2 16 Nov 2015 avatar dgt41 fixes
17adc45 16 Nov 2015 avatar dgt41 cs
b03b1ac 16 Nov 2015 avatar dgt41 cs
avatar roland-d roland-d - test_item - 16 Nov 2015 - Tested successfully
avatar roland-d
roland-d - comment - 16 Nov 2015

I have tested this item :white_check_mark: successfully on 2b774e6

After applying the patch, the modals show up in the desired size and the padding is applied.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8366.

avatar Fedik Fedik - test_item - 18 Nov 2015 - Tested successfully
avatar Fedik
Fedik - comment - 18 Nov 2015

I have tested this item :white_check_mark: successfully on 2b774e6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8366.

avatar dgt41 dgt41 - change - 18 Nov 2015
Status Pending Ready to Commit
avatar dgt41 dgt41 - change - 18 Nov 2015
Title
tinyMCE DRY for the inline script
tinyMCE DRY for the inline script
avatar dgt41
dgt41 - comment - 18 Nov 2015

@joomla-cms-bot are you sleeping?

avatar joomla-cms-bot joomla-cms-bot - change - 18 Nov 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 18 Nov 2015

Cool @dgt41 i also got worried about him. Thanks for wake up @joomla-cms-bot :)

avatar rdeutz rdeutz - close - 18 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 18 Nov 2015
avatar rdeutz rdeutz - reference | c170fae - 18 Nov 15
avatar rdeutz rdeutz - merge - 18 Nov 2015
avatar rdeutz rdeutz - close - 18 Nov 2015
avatar rdeutz rdeutz - change - 18 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-18 19:00:25
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 18 Nov 2015
Labels Removed: ?
avatar dgt41 dgt41 - head_ref_deleted - 18 Nov 2015

Add a Comment

Login with GitHub to post a comment