?
avatar Globulopolis
Globulopolis
9 Nov 2015

After latest Joomla updates(starting from 3.4.3) debug console stop working to show explain and profile information for queries.
This is that I see in console
clipboard01
No changes has been made on server from Joomla 3.4.3 to Joomla 3.4.5.

avatar Globulopolis Globulopolis - open - 9 Nov 2015
avatar zero-24 zero-24 - change - 9 Nov 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 Nov 2015
Category Plugins
avatar brianteeman
brianteeman - comment - 11 Nov 2015

I can confirm this


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8362.

avatar infograf768
infograf768 - comment - 11 Nov 2015

Tested by changing in staging current debug.php by the file released in 3.4.2, 3.4.3 and 3.4.4 and I confirm that it is broken since 3.4.4.

The PR concerned is
#7279

avatar alikon
alikon - comment - 12 Nov 2015

reverting #7279 works as expected

avatar infograf768
infograf768 - comment - 12 Nov 2015

As far as I understood, we can't revert this as it can create issues for users implementing "register_shutdown_function()" callbacks in extensions.
Another solution is required.

avatar mbabker
mbabker - comment - 12 Nov 2015

The reason it worked before #7279 is because of the order of shutdown of the various objects. The database driver's destructor would get called before the system plugin's destructor, and the database driver destructor calls a shutdown routine (usually $this->disconnect()). In order to make the log data work again without reverting #7279 in the debug plugin you will need to call $db->disconnect() before starting to get all the data out of the driver.

Reverting #7279 will send an implicit message that Joomla does not offer 100% feature support for cases where someone registers a custom shutdown function via register_shutdown_function(). Logic like rendering the debug console should not be placed in a class destructor for this reason.

avatar zero-24
zero-24 - comment - 12 Nov 2015

Closing as we have a PR by @alikon. Thanks

avatar zero-24 zero-24 - change - 12 Nov 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-11-12 18:34:37
Closed_By zero-24
avatar zero-24 zero-24 - close - 12 Nov 2015

Add a Comment

Login with GitHub to post a comment