[#8356] - Debug Language: Star (*) is OK in lang constant
- Closed
- 11 Nov 2015
- Medium
- Build: staging
- Easy Test
- # 8356
- Diff
- infograf768:ini_parse_star
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
As of today, a language constant containing a star will trigger a parse error when debug language is on.
Some extensions like sobibro do use stars in their constants.
SP.PERMISSIONS.DELETE_*="delete any"
It is not mandatory to throw an error if there is a star as the translation works fine
This patch prevents the parse error.
To test, modify a string, for example in en-GB.config.ini:
Change
COM_CONFIG_DEBUG_SETTINGS="Debug Settings"
to
COM_CONFIG_DEBUG_SETTINGS*="Debug Settings"
Then modify in ROOT/administrator/components/com_config/view/application/tmpl/default_debug.php
$this->name = JText::_('COM_CONFIG_DEBUG_SETTINGS');
to
$this->name = JText::_('COM_CONFIG_DEBUG_SETTINGS*');
Go to Global Configuration => System and enable Debug Language
The translation works.
Look at the bottom of the page: there is an error in Parsing Error in language files (it shows red)
Patch and test again.
No more parsing error.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Language & Strings |
| Easy | No | ⇒ | Yes |
Tested also on 3.5.0 and works4me
Cheers
| Status | Pending | ⇒ | Ready to Commit |
2 good tests. RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8356.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-11 08:55:20 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on edcdd0a
Tested on 3.5.0: works fine
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8356.