Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8354] - Utilize safe string methods in JCrypt

? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
9 Nov 2015

This pull request implements the safe string helper methods from \ParagonIE\Halite\Util (essentially as a fork since that library requires PHP 5.6) and utilizes the safeStrlen() method in our JCrypt::timingSafeCompare() method to address the issue raised in #8330.

avatar mbabker mbabker - open - 9 Nov 2015
avatar mbabker mbabker - change - 9 Nov 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2015
Labels Added: ?
avatar paragonie-scott
paragonie-scott - comment - 9 Nov 2015

:+1: There are other instances that need to be updated but that can come later.

avatar zero-24 zero-24 - change - 9 Nov 2015
Category ⇒ Libraries
avatar wilsonge wilsonge - change - 9 Nov 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-11-09 22:09:40
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 9 Nov 2015
avatar wilsonge wilsonge - reference | 7eb70ea - 9 Nov 15
avatar wilsonge wilsonge - merge - 9 Nov 2015
avatar wilsonge wilsonge - close - 9 Nov 2015
avatar wilsonge
wilsonge - comment - 9 Nov 2015

Merged on review

avatar wilsonge wilsonge - change - 9 Nov 2015
Milestone Added:
avatar mbabker mbabker - head_ref_deleted - 9 Nov 2015
avatar beat
beat - comment - 14 Nov 2015

Code reviewed :+1:

Add a Comment

Login with GitHub to post a comment