? ? ? Failure

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
9 Nov 2015

This PR adds to Extensions: Update the current version of an extension. The current list of extensions that could be updated to a newer version only shows the new version number.

This feature was requested by wkone in Joomla forum http://forum.joomla.org/viewtopic.php?f=708&t=898474. I think that showing the current and new version gives an administrator more information about possible issues: If the extensions uses semantic versioning then 2.1 to 2.2 is a minor update with little issues. An update from 2.9 to 3.1 might give somewhat more issues.

Testing Instructions

I had to test this feature on a Joomla 3.4.5 website because I was not able to use the "Extension: Update" funtion in Joomla 3.5Beta1. After installing some old versions of some extensions in 3.5Beta1 I did not get the list of updates for those extensions. Probably because those extensions do not have new versions for 3.5Beta1...

Edit: Workaround to test this patch on Joomla 3.5Beta1:
manually edit libraries/cms/version/version.php and temporary change the constant for Release & Development level:
const RELEASE = '3.4.5';
const DEV_LEVEL = 'stable';
With these values Joomla will find new extension updates for old 3rd party extensions.

Don't forget to change it back to the original values after testing this patch. Original values:
const RELEASE = '3.5';
const DEV_LEVEL = '0-beta';

Before the PR

I've installed 3 older versions of extensions that use Joomla's update functionality.
Extensions: Update (via Extensions > Manage > Update) shows that there are 3 updates that can be installed. It shows the version of the extension that will be installed but not the current version

com_installer-update-current-version-before

After the PR

After installing this PR the Extensions: Update (via Extensions > Manage > Update) shows Current version and Version (that will be installed)

com_installer-update-current-version-after

avatar pe7er pe7er - open - 9 Nov 2015
avatar pe7er pe7er - change - 9 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2015
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2015
Labels Added: ? ?
avatar pe7er
pe7er - comment - 9 Nov 2015

I've changed the label "Version" to "Update to Version" to make it more clear that its the number of the new version.

avatar waader waader - test_item - 9 Nov 2015 - Tested successfully
avatar waader
waader - comment - 9 Nov 2015

I have tested this item :white_check_mark: successfully on b06292c

:+1:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

avatar infograf768
infograf768 - comment - 9 Nov 2015

Nice.
I could test easily on staging for some extensions who do not specify the minor J version.
screen shot 2015-11-09 at 17 51 28

avatar infograf768 infograf768 - test_item - 9 Nov 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 9 Nov 2015

I have tested this item :white_check_mark: successfully on b06292c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

avatar zero-24 zero-24 - change - 9 Nov 2015
Status Pending Ready to Commit
Labels
avatar zero-24 zero-24 - change - 9 Nov 2015
Category Administration UI/UX
avatar zero-24
zero-24 - comment - 9 Nov 2015

@roland-d please decide if this can go into 3.5

RTC Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2015
Labels Added: ?
avatar roland-d roland-d - change - 10 Nov 2015
Labels Added: ?
avatar roland-d roland-d - change - 10 Nov 2015
Milestone Added:
avatar brianteeman
brianteeman - comment - 11 Nov 2015

I think "Available Version" is better?
"Update to" describes an action not some information


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

avatar joomla-cms-bot
joomla-cms-bot - comment - 11 Nov 2015

This PR has received new commits.

CC: @infograf768, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

avatar pe7er
pe7er - comment - 11 Nov 2015

Thanks for testing @waader & @infograf768 !

Good point @brianteeman!
I've just changed the language string to "Available Version"

avatar brianteeman
brianteeman - comment - 11 Nov 2015

Thanks for doing that @pe7er


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

avatar brianteeman brianteeman - test_item - 12 Nov 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Nov 2015

I have tested this item :white_check_mark: successfully on d8deaed

Works as intended thanks

As a small visual improvement if you remove the 10% on the th then you wont get the ugly/inconsistent wrapping on the titles


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

avatar pjwiseman pjwiseman - test_item - 26 Nov 2015 - Tested successfully
avatar pjwiseman
pjwiseman - comment - 26 Nov 2015

I have tested this item :white_check_mark: successfully on d8deaed

Nice feature.

Whilst removing the 10% width on the version fields does avoid the inconsistent title wrappings, it does that at a cost of a rather wide field on a wide display. I'd swing either way. Hence, it's a successful test.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8350.

avatar pe7er
pe7er - comment - 5 Jan 2016

Thanks @nonumber !
I'll try to correct the patch with your corrected code soon...

avatar wilsonge
wilsonge - comment - 17 Jan 2016

I'm going to close this in favour of the code proposed by @nonumber in #8768

avatar wilsonge wilsonge - change - 17 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-17 15:08:15
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar wilsonge wilsonge - change - 17 Jan 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment