[#8317] - Fixed layout long titles + text in beez3 template
- Fixed in Code Base
- 7 May 2016
- Medium
- Build: staging
- Easy Test
- # 8317
- Diff
- pe7er:beez-title-wordwrap
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR fixes the layout of long article titles & text articles in the Beez3 template.
Similar problem as this PR for Protostar template: #8312
Testing Instruction
Before the PR
Create a new article
Content > Article > [New]
Use a very long title + article text that has no spaces or hyphens -
See instruction of: #8312
And set the Beez3 template as Default Template:
Extensions > Templates > select "Beez3 - Default" & set as default (or click on the star)
Front-end with Beez3 template looks weird
The front-end view of the Beez template does not break the title and text, and those both mess up the layout.
After the PR
I've added word-wrap: break-word; to body h1,body h2,body h3,body h4,body h5,body h6 { and body p,body ol,body ul,body dl,body address { of /templates/beez3/css/layout.css
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Templates (site) |
| Easy | No | ⇒ | Yes |
I have tested this item 
successfully on 037b0b2
Applied patch and test was successful
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.
I have tested this item successfully on 037b0b2
Tested successfully in Beez3
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.
Doesn't that also break words when there would be a space within the title? From what I know word-wrap: break-word does break a word whenever it reachs the end of the line, doesn't matter if there would have been a space or not.
I don't think that is a behaviour we want. Yes, for very long titles without any spaces we would need it, but for long titles with spaces in it (which probably are far more often) it would be a very bad change.
What is the usecase where you have such a long "one-word" title? Wouldn't there be better solutions than using break-word in that case?
See my comment here:
#8312 (comment)
| Status | Pending | ⇒ | Needs Review |
Based on @bakual comments I am setting this to Needs Review for a maintainer to make a decision
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.
I have tested this item successfully on 037b0b2
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.
I can't find any documentation about the behaviour Thomas mentioned merging
| Status | Needs Review | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-07 11:19:28 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
I have tested this item
successfully on 037b0b2
Thanks pe7er!
I spotted another candidate for you in protostar > latest articles.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.