? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
7 Nov 2015

See: #8285

What this basically does:
— Normalise the description constant to PLG_SYSTEM_UPDATENOTIFICATION_XML_DESCRIPTION
— Corrects the tip for the Language field to:

PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_DESC="If you choose Auto (default), the update notification email to Super Users may be in the logged in user's front-end language or, if a user is not logged in, in the default site language of the page at the time the plugin is triggered.<br />This can create confusion on sites where multiple languages are installed (multi-language sites or not): the language of the page loaded when the plugin is triggered may be one the Super User receiving the email doesn't speak. By selecting a language here you are forcing the update notification emails to be sent in this specific language."`

--Corrects the email body message to obtain nicer newlines
One will now get (this capture shows the message when \n are changed to returns:
screen shot 2015-11-07 at 11 59 27

avatar infograf768 infograf768 - open - 7 Nov 2015
avatar infograf768 infograf768 - change - 7 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2015
Labels Added: ? ?
avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Added:
avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Added:
avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Added:
avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Added:
avatar zero-24 zero-24 - change - 7 Nov 2015
Milestone Removed:
avatar brianteeman
brianteeman - comment - 7 Nov 2015

Sorry I have to disagree with this. The content you have added is correct but it belongs in documentation off site and not in a tooltip or on a web page. We dont have such detailed text for everything else which covers all possible explanations and scenarios.

avatar infograf768
infograf768 - comment - 7 Nov 2015

@brianteeman
This one is extremely important. Please compare with former one which was wrong.

PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_DESC="If you choose Auto (default), the update notification email to Super Users will be in the logged in user's front-end language at the time the plugin is triggered. In multi-language sites this can create confusion: the user's language may be one the Super User receiving the email doesn't speak. By selecting a language here you are forcing the update notification emails to be sent in this specific language."

avatar infograf768
infograf768 - comment - 8 Nov 2015

@brianteeman
We could also simplify more this way:

PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_DESC="If you choose Auto (default), the update notification email to Super Users will be in the site language of the page displayed at the time the plugin is triggered.
On sites where multiple languages are installed (multilingual sites or not): the language of the page loaded may be one the Super User receiving the email doesn't speak. By selecting a language here you are forcing the update notification emails to be sent in this specific language."

What do you think?

avatar brianteeman
brianteeman - comment - 8 Nov 2015

How about even simpler

PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_DESC="If you choose Auto
(default), the update notification email to Super Users will be in the site
language at the time the plugin is triggered.
By selecting a language here you are forcing the update notification emails
to be sent in this specific language."

On 8 November 2015 at 08:20, infograf768 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman
We could also simplify more this way:

PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_DESC="If you choose Auto
(default), the update notification email to Super Users will be in the site
language of the page displayed at the time the plugin is triggered.
On sites where multiple languages are installed (multilingual sites or
not): the language of the page loaded may be one the Super User receiving
the email doesn't speak. By selecting a language here you are forcing the
update notification emails to be sent in this specific language."
What do you think?


Reply to this email directly or view it on GitHub
#8315 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 9 Nov 2015

@brianteeman
Your proposal, I think, is missing the necessary explanation of the simple reason why one should choose a specific language instead of Auto on some sites. After all, my last proposal above is only one line more.

avatar Bakual
Bakual - comment - 9 Nov 2015

Imho, the one Brian proposed is clear enough and simple to understand. To me it would be clear that "the site language at the time the plugin is triggered." may not be my preferred language.

avatar infograf768
infograf768 - comment - 9 Nov 2015

OK, OK... Modification done. Let's get this i.n

avatar zero-24 zero-24 - test_item - 9 Nov 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 9 Nov 2015

I have tested this item :white_check_mark: successfully on a3ee5c3


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8315.

avatar zero-24 zero-24 - change - 9 Nov 2015
Category Language & Strings
avatar zero-24 zero-24 - change - 9 Nov 2015
Status Pending Ready to Commit
Labels
avatar zero-24
zero-24 - comment - 9 Nov 2015

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8315.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2015
Labels Added: ?
avatar rdeutz rdeutz - reference | e3ef0de - 9 Nov 15
avatar rdeutz rdeutz - change - 9 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-09 09:24:14
Closed_By rdeutz
avatar rdeutz rdeutz - merge - 9 Nov 2015
avatar rdeutz rdeutz - close - 9 Nov 2015
avatar infograf768 infograf768 - head_ref_deleted - 9 Nov 2015
avatar wilsonge wilsonge - change - 17 Jan 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment