Closed
16 Nov 2015
Medium
Build: staging
Easy Test
# 8313
Diff
pe7er:com_search_filter_nullbyte

Success

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

pe7er
7 Nov 2015

This PR filters fixes a problem with nullbyte that I found using com_search.

Testing instructions

Before the PR

Search keyword with nullbyte %00

On the front-end use the Search Module or Search Component and search for a keyword containing a nullbyte %00, eg test%00

Joomla crashes on nullbyte %00

with error message:
Warning: Header may not contain NUL bytes in /www/joomla-cms/libraries/joomla/application/web.php on line 960

After the PR

After this PR the nullbyte will be stripped from the Header and search will work correctly.

Votes

# of Users Experiencing Issue

1/1

Average Importance Score

3.00

88bbca6 7 Nov 2015

filter nullbyte

pe7er - open - 7 Nov 2015

pe7er - change - 7 Nov 2015

Status

New

⇒

Pending

joomla-cms-bot - change - 7 Nov 2015

Labels

Added: ?

pe7er - change - 7 Nov 2015

Title

…

Filter nullbyte ~~in Header, feeded via com_search~~

Filter nullbyte (feeded via com_search) in Header

waader - test_item - 7 Nov 2015 - Tested successfully

waader - comment - 7 Nov 2015

I have tested this item successfully on 88bbca6

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8313.}

zero-24 - change - 9 Nov 2015

Category

Search SQL

⇒

RonakParmar - comment - 10 Nov 2015

I have tested this item successfully on 88bbca6

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8313.}

zero-24 - alter_testresult - 10 Nov 2015 - RonakParmar: Tested successfully

zero-24 - change - 10 Nov 2015

Milestone	Added:
Status	Pending	⇒	Ready to Commit

zero-24 - change - 10 Nov 2015

Milestone

Added:

zero-24 - comment - 10 Nov 2015

RTC. Thanks.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8313.}

joomla-cms-bot - change - 10 Nov 2015

Labels

Added: ?

pe7er - comment - 10 Nov 2015

Thanks for testing @waader & @RonakParmar !

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8313.}

rdeutz - change - 16 Nov 2015

Status	Ready to Commit	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2015-11-16 20:28:22
Closed_By		⇒	rdeutz

rdeutz - close - 16 Nov 2015

joomla-cms-bot - close - 16 Nov 2015

joomla-cms-bot - change - 16 Nov 2015

Labels

Removed: ?