[#8290] - Parse the returned text to make sure HTML entities show correctly.
- Closed
- 5 Nov 2015
- Medium
- Build: staging
- # 8290
- Diff
- roland-d:parse-ajax-html-installation
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Problem
As shown in the screenshot, HTML entities are not converted because of the AJAX call.
Solution
This PR parses the returned string as HTML and then puts it out so it shows as correct text
Test
- Get a clean copy of the Joomla staging branch or download it here
- Go through the installation process in German
- After reaching the last page when the installation is complete click on the button
Verzeichnis „installation” löschen - You will see the resulting text
Das Verzeichnis „installation“ wurde gelöscht! - Setup a clean installation again
- Replace the file installation/template/js/installation.js with the file attached here or just replace line 308 as shown in the file change
- Go through the installation process in German again
- After reaching the last page when the installation is complete click on the button
Verzeichnis „installation” löschen - You will see the resulting text
Das Verzeichnis „installation” wurde gelöscht! - All is good now.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
@Kubik-Rubik It's good to see it is already fixed but why isn't going to be in for 3.5 when this was fixed nearly 3 weeks ago?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-05 21:05:09 |
| Closed_By | ⇒ | roland-d |
The sync request is here: joomlagerman/joomla#152
@Kubik-Rubik Since it's the installation folder, it will not be part of the language pack. It will be shipped with the core.
But we usually do a single round of installation language files updates before a release. After we froze languages for the installation folder.
So yes, this will be fixed for 3.5.0.
I have tested this item 
successfully on d8624d3
Works fine, good work.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8290.
I have tested this item
successfully on d8624d3
works for me,
tested with MAMP on OSX, PHP 5.6.10, Safari, Chrome & FF
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8290.