? Pending

User tests: Successful: Unsuccessful:

avatar Kubik-Rubik
Kubik-Rubik
5 Nov 2015

Please see #8274 and #8057 for more details.

We need to correct the nested sets after we've removed one entry in the menu.

Thanks to @matrikular and @roland-d for providing valued input on this topic.

How to test?

Do an installation and an update (with the changed files included in the package) and check whether the menu still works properly!

avatar Kubik-Rubik Kubik-Rubik - open - 5 Nov 2015
avatar Kubik-Rubik Kubik-Rubik - change - 5 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Nov 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 5 Nov 2015
Milestone Added:
avatar waader
waader - comment - 5 Nov 2015

@Kubik-Rubik With #8274 I checked the component menus and the worked. So obviously that was not enough. I have to check all menu items, right?

avatar Kubik-Rubik
Kubik-Rubik - comment - 5 Nov 2015

@waader It should also work with #8274 but the values are just not correct there. With this PR they were corrected.

avatar waader
waader - comment - 5 Nov 2015

Something I observed while getting prepared to test this patch. I installed the current staging branch and then went to Manage > Database. There I get this items:

able 'v1j2o_banners' does not have column 'alias' with type 'varchar(191)'. (From file 3.5.0-2015-07-01.sql.)
Table 'v1j2o_categories' does not have column 'alias' with type 'varchar(191)'. (From file 3.5.0-2015-07-01.sql.)
Table 'v1j2o_contact_details' does not have column 'alias' with type 'varchar(191)'. (From file 3.5.0-2015-07-01.sql.)
Table 'v1j2o_content' does not have column 'alias' with type 'varchar(191)'. (From file 3.5.0-2015-07-01.sql.)
Table 'v1j2o_menu' does not have column 'alias' with type 'varchar(191)'. (From file 3.5.0-2015-07-01.sql.)
Table 'v1j2o_newsfeeds' does not have column 'alias' with type 'varchar(191)'. (From file 3.5.0-2015-07-01.sql.)
Table 'v1j2o_tags' does not have column 'alias' with type 'varchar(191)'. (From file 3.5.0-2015-07-01.sql.)
Table 'v1j2o_ucm_content' does not have column 'core_alias' with type 'varchar(191)'. (From file 3.5.0-2015-07-01.sql.)

Can you adapt joomla.sql appropriately?

avatar Kubik-Rubik
Kubik-Rubik - comment - 5 Nov 2015

@waader Thank you for the hint, I will fix it now.

avatar Kubik-Rubik
Kubik-Rubik - comment - 5 Nov 2015

@waader @infograf768 Please test the update. Do a fresh installation and check whether database errors are displayed in "Extensions" - "Manage" - "Database".

avatar infograf768
infograf768 - comment - 5 Nov 2015

Database Up to date. OK for me

avatar Kubik-Rubik
Kubik-Rubik - comment - 5 Nov 2015

@infograf768 Thanks! And the menus are working properly? If yes, please mark as tested successfully. Thank you!

avatar waader waader - test_item - 5 Nov 2015 - Tested successfully
avatar waader
waader - comment - 5 Nov 2015

I have tested this item :white_check_mark: successfully on 03e6fd1

Thanks Kubik-Rubik!

I have tested mysql, postgres and mssql.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8284.

avatar wilsonge
wilsonge - comment - 5 Nov 2015

Can we try and split things up please. Let's keep all the stuff for the alias's in @zero-24 's PR #8268 (just PR the non-mysql database changes for that into there) and keep this specific to that menu change.

For the menu changes. The old values 18-20 were for weblinks. So any testers MUST make sure at minimum they test starting at 3.3.6 and upgrading through the versions to this version. To be honest whilst I don't mind what we start new installs on I see upgrading existing installs as very risky and bug prone - it could leave people with two items with the same lft value in a worst case scenario. This is why we have the rebuild button in the menu manager and don't do update queries for menus pretty much ever.

avatar Kubik-Rubik
Kubik-Rubik - comment - 5 Nov 2015

@wilsonge Ah, I didn't see @zero-24's PR. I think then the best solution would be to close this PR and maybe add a notification to users that they should press the rebuild button once?

avatar waader
waader - comment - 5 Nov 2015

I didnĀ“t see this neither. @Kubik-Rubik. you also have the date changes for postgres.

avatar Kubik-Rubik
Kubik-Rubik - comment - 5 Nov 2015

I will close this PR in favor of #8268 and #8284 (comment).

avatar Kubik-Rubik Kubik-Rubik - change - 5 Nov 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-11-05 22:04:00
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 5 Nov 2015
avatar Kubik-Rubik Kubik-Rubik - close - 5 Nov 2015
avatar Kubik-Rubik Kubik-Rubik - change - 5 Nov 2015
Milestone Removed:
avatar Kubik-Rubik Kubik-Rubik - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment