? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
4 Nov 2015

The problem

Select either none or code mirror as your editor
Edit an article
Try inserting a module by name or position
An error is logged in your browsers console

The fix

Pass a var to specify the editor’ id in the script

Test

Apply this patch and repeat the above procedure

avatar dgt41 dgt41 - open - 4 Nov 2015
avatar dgt41 dgt41 - change - 4 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Nov 2015
Labels Added: ?
avatar zero-24 zero-24 - test_item - 4 Nov 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 4 Nov 2015

I have tested this item :white_check_mark: successfully on 1f43f48

Works now. Thanks @dgt41 one more tester


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8269.

avatar zero-24 zero-24 - change - 4 Nov 2015
Milestone Added:
Easy No Yes
avatar zero-24 zero-24 - change - 4 Nov 2015
Milestone Added:
avatar zero-24 zero-24 - change - 4 Nov 2015
Category Plugins
6b30151 4 Nov 2015 avatar dgt41 CS
b1109fd 4 Nov 2015 avatar dgt41 CS
avatar zero-24 zero-24 - alter_testresult - 4 Nov 2015 - zero-24: Tested successfully
avatar zero-24 zero-24 - test_item - 4 Nov 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 4 Nov 2015

I have tested this item :white_check_mark: successfully on b1109fd

Still works (just a CS fix)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8269.

avatar zero-24 zero-24 - test_item - 4 Nov 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 4 Nov 2015

I have tested this item :white_check_mark: successfully on 875ebf0

Still works with the last commit.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8269.

avatar roland-d roland-d - test_item - 4 Nov 2015 - Tested successfully
avatar roland-d
roland-d - comment - 4 Nov 2015

I have tested this item :white_check_mark: successfully on 875ebf0

Before I get a JavaScript error trying to add in a module, after applying the patch the module is added correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8269.

avatar roland-d roland-d - change - 4 Nov 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 4 Nov 2015

@joomla-cms-bot please add the RTC label.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8269.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Nov 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 4 Nov 2015

Thanks @dgt41 and testers! Merged.

avatar Kubik-Rubik Kubik-Rubik - change - 4 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-04 13:58:05
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 4 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 4 Nov 2015
avatar Kubik-Rubik Kubik-Rubik - reference | 46b6aa9 - 4 Nov 15
avatar Kubik-Rubik Kubik-Rubik - merge - 4 Nov 2015
avatar Kubik-Rubik Kubik-Rubik - close - 4 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 4 Nov 2015
Labels Removed: ?
avatar dgt41 dgt41 - head_ref_deleted - 4 Nov 2015

Add a Comment

Login with GitHub to post a comment