[#8260] - Allow numeric characters in format variable (Ref #8259)
- Fixed in Code Base
- 14 Aug 2016
- Medium
- Build: staging
- # 8260
- Diff
- subtext:expanded-document-types
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This change will allow document types to accept extensions with
alphanumeric characters such as m4v, mp3, and mp4. Because the JDocument class is loaded from JFactory, it becomes exceedingly difficult to override this behavior in extensions.
In the JFactory class the format variable retrieved from the request uses the 'word' filter which strips out all numeric characters from the variable value and leaves only alpha characters. In order to add document types for video files such as m4v, mp4, etc... this change is needed to JDocument types which include numeric characters. Consider this example:
$link = JRoute::_('index.php?option=com_video&format=m4v&id=y2VLUEh6crVq4hfV');The router for the custom component returns a link in the form:
http://mysite.com/videos/y2VLUEh6crVq4hfV.m4v
However, following that link you will receive a view not found error message because the "type" variable will be returned as "mv" instead of "m4v" as the filter variable for JInput will strip out the numeric characters.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
I have tested this item
Tested with vardump, the Error was repeatable, the 4 in .m4v was lost without the Patch.
With the Patch it was there.
@icampus WPW
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8260.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
I would classify this as a bug
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-14 10:59:33 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 5aba7a9
I tested it @icampus wpw,
I cannot reproduce the error but created another link with a numeric character and do a vardump in /libraries/joomla/factory.php in the createDocument to display the type. It was by m4v only m4 because of the 'word' filter. After the patch the filter is working fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8260.