[#8235] - Avoid duplicated language load calls
- Closed
- 6 Nov 2015
- Medium
- Build: staging
- # 8235
- Diff
- phproberto:language
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
From @mbabker :
With the extra check in there to load the default language if the $lang param doesn’t match the default, it ends up with a lot of duplicated calls… plus in the case of that method specifically, it was trying to load the template’s language file for every module position in the template, so that forces the helper to only try loading the template language file once per template instead of letting JLanguage deal with it
Before:
After:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Administration Language & Strings |
I have tested this item 
successfully on 9f8d756
Tested by checking that the template positions are still translated when editing a module in back-end when language is not en-GB.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8235.
Restarted the tests that failed last night and all now good from that perspective.
I have tested this item successfully on 9f8d756
I tested like infograf768 described it. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8235.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-06 19:28:08 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
PR is currently failing because of downtime in pecl.php.net - as you can see the rest of the tests pass in other PHP versions - so assume they will pass in 5.5 and 5.6 for now and we will restart the build when it comes online