? ? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
1 Nov 2015

Suggested pull allow to turn off checks for not used types,
this can improve page rendering speed on huge site.

test
apply patch and make sure that all still work as before

ps. I need help with better strings for labels and descriptions, can someone suggest better?

avatar Fedik Fedik - open - 1 Nov 2015
avatar Fedik Fedik - change - 1 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2015
Labels Added: ? ?
b6f9de6 1 Nov 2015 avatar Fedik c.s.
avatar zero-24 zero-24 - change - 2 Nov 2015
Labels
avatar zero-24 zero-24 - change - 2 Nov 2015
Category Language & Strings Plugins
avatar zero-24 zero-24 - change - 2 Nov 2015
Easy No Yes
avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Nov 2015

I understand what you are tring to do here. complex preg_replace is very expensive.
How much ms did you manage to save with this code?

Netherless, i don't know if adding more options ... is the best way to achieve the goal.

Isn't there any way to optimize the regexs or for instance do a strpos before making the regex? Many pages don't have object or onclick or whatever... maybe some ms can be saved with this.

check this for instance http://stackoverflow.com/questions/29726949/is-using-strpos-before-preg-replace-faster

avatar Fedik Fedik - change - 15 Feb 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-02-15 17:37:23
Closed_By Fedik
avatar Fedik Fedik - close - 15 Feb 2016
avatar Fedik Fedik - head_ref_deleted - 15 Feb 2016

Add a Comment

Login with GitHub to post a comment