[#8227] - Fixed the modal filter to not use the search value of the category list
- Closed
- 4 Nov 2015
- Medium
- Build: staging
- # 8227
- Diff
- roland-d:fix-modal-language-8222
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The association modal was broken due to the filters automatically set on chosen options in another screen. The modal now uses it's own search field.
This fixes #8222 and test instructions can be found there. The output should now be the expected result after applying this fix.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item 
successfully on 57e0c37
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8227.
This does not work correctly here. The only aspect changed is that it now displays the correct list of categories in the chosen associated language, which is indeed much better.
Search in the modal does not give any result. It just display again the whole list of items. When searching, the field keeps the value given in the manager and does not change when one enters another value or when clearing.
After choosing a category in the modal, when coming back to the Manager, the Search Tools Language filter is set to the Language chosen for the association (really wrong) and the search field has exactly the same value as before, which basically displays an empty list as the item searched in the Manager originally was in another language.
The search in the modal is still totally broken, even when not having searched first in the Manager.
See https://www.dropbox.com/s/vnawvxgxqf51bfg/modal.mp4?dl=0
I have tested this item 
unsuccessfully on 57e0c37
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8227.
| Milestone |
Added: |
||
Search in modal now works. :)
One issue remains, when save and close and redirecting to the manager, the manager is filtered by the associated language as I explained above.
This will explain better than words. The original category is tagged to French. I confirm the choice for an en-GB item in the modal.
https://www.dropbox.com/s/duvijfoy196ouyp/category_filter.mp4?dl=0
Forgot to say that we do not have this issue when doing the same for articles.
| Category | ⇒ | Administration |
This PR has received new commits.
CC: @infograf768, @n9iels
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8227.
@infograf768 That remark about articles was spot on. I think I have a cleaner solution now.
I have tested this item successfully on 4ba2308
That is now totally OK. One more test to get this in. :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8227.
I have tested this item successfully on 4ba2308
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8227.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8227.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-04 13:59:24 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
After applying the patch, the French category is visible, but I still can't search for another category.
I search for the category "park site", when I search in the modal of the associate tab the value of the search field still keeps "Park site" when I hit the search button.