? ? ? Pending

User tests: Successful: Unsuccessful:

avatar wnnz34
wnnz34
29 Oct 2015

Introduction

This joomla extension gives the user in the installation Modus in joomla to choose the functionality he or she wants to use for the installation.
These following plugins: urlFolderInstaller and packageInstaller are plugins which have the same functionalities as Install from url, install from folder path and upload from package. urlFolderInstaller Plugin allow the user not only to install from a path folder, but also from an url. And PackageInstaller allow the user to install from an extension file (zip Package).These plugin can also be disabled so that the user can just use what she or he wants to use. The advantage of this Solution is the flexibility of the User.

Fix

After the installation, the plugin have to be already in Extension / Manage enabled. There is only 2 columns installation: Install from url or path folder functionalities of the plugin urlFolderInstaller and upload from package File functionality of packageInstaller plugin.

How to test it.

  • Login as Administrator
  • Go to Extension / Manage:
  • Install a plugin by entering an url or folder path in Install from url or folder.
  • Check and test.
  • Install a Plugin from package zip
  • Check and test
  • Disable one of the Plugin in Extension / plugins: Enter the name and search for the plugin you want to disable in the installation Modus (urlFolderInstaller or packageInstaller)
  • Disable one of the plugin and test the remaining plugin installation
  • Check the ordering Extension / plugin and search for the plugin -> and test the ordering by choosing a position and save.
  • Go to Extension / manage and check the position of the Plugin you just changed the ordering position.

worked as a group on that issue: @icampus , @Mpompejus , @G-Lu

avatar wnnz34 wnnz34 - open - 29 Oct 2015
avatar wnnz34 wnnz34 - change - 29 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2015
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 29 Oct 2015

What are these German and French ini files doing here?

avatar roland-d
roland-d - comment - 29 Oct 2015

I think it is a mistake in the commit :)

avatar wnnz34
wnnz34 - comment - 29 Oct 2015

@infograf768 what do you mean ? ... the ini files (french , german) are for the stranslation , in case the user is using joomla in another language like french or german

avatar Wolf-Rost
Wolf-Rost - comment - 30 Oct 2015

I removed the unnecessary language folders from the plugins. Everything should be fine now. :)

avatar zero-24 zero-24 - change - 30 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 30 Oct 2015
Category Administration Plugins
avatar zero-24 zero-24 - change - 30 Oct 2015
Labels
Easy No Yes
avatar wnnz34 wnnz34 - change - 30 Oct 2015
Labels
avatar roland-d
roland-d - comment - 1 Nov 2015

@Wolf-Rost There are conflicts, can you check please?

avatar Wolf-Rost
Wolf-Rost - comment - 1 Nov 2015

The conflicts are solved. Feel free to test it now. :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar zero-24
zero-24 - comment - 1 Nov 2015

@Wolf-Rost and @wnnz34 i have just add a new PR that fixes the lang file load issue see: wnnz34#3

For testing it looks good but we need to do 2 things more to make this happen.

  • Add the new plugins to the script.php (com_admin)
  • Add Update SQL (com_admin)

A very importand point is that both plugins should be enabled by default and on updating (e.g. via script or SQL update files)

An Improvmend could be maybe to send a message if there are no installer plugins enabled to tell the user something like:

You have no installer plugin enabled. To be able install extensions you need to enable atleast on Plugin of the type installer.

avatar wnnz34
wnnz34 - comment - 1 Nov 2015

@zero-24 All checks have Failed by Merging pleas check it

avatar zero-24
zero-24 - comment - 2 Nov 2015

The travis checks errored because a upstream domain is down where we get on component fpr the tests. The tests fail only on two php versions so if that domain comes back we can restart the build ans they will pass :)

avatar brianteeman
brianteeman - comment - 11 Nov 2015

I have restarted Travis


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar zero-24
zero-24 - comment - 11 Nov 2015

Thanks @brianteeman @wnnz34 can you fix the merge conflicts here?

avatar Wolf-Rost
Wolf-Rost - comment - 16 Nov 2015

I fixed the merge conflicts.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar bertmert bertmert - test_item - 17 Jan 2016 - Tested unsuccessfully
avatar bertmert
bertmert - comment - 17 Jan 2016

I have tested this item :red_circle: unsuccessfully on c7a4be4

After applying this patch in Joomla! 3.5.0-beta — staging 2016-01-17 go to Extensions > Manage > Install.
No tabulators, no search tools, no way to install something.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar brianteeman brianteeman - test_item - 14 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Apr 2016

I have tested this item :white_check_mark: successfully on c7a4be4

Took me a while to work out what this PR is trying to do so I will write down my findings to help others.

  1. In the Joomla installer (administrator/index.php?option=com_installer) we currently have three tabs Upload Package File Install from Folder Install from URL or 4 if you have the install from web plugin

This PR combines Install from Folder and Install from URL into a single tab so there are only two tabs
Install from URL or Path Folder
Upload Package File
or 3 if you have the install from web plugin

  1. This PR then moves control of those tabs to their own plugins just like the install from web plugin This means that as a site admin you are able to disable one or other or even both


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar brianteeman brianteeman - change - 14 Apr 2016
Category Administration Plugins Administration Feature Request Plugins
avatar brianteeman brianteeman - change - 14 Apr 2016
Labels
Easy Yes No
avatar brianteeman
brianteeman - comment - 14 Apr 2016

[NOTE] This PR can not be tested with com_patchtester so you will either need to use git or you can download a complete joomla install with this PR applied from https://github.com/wnnz34/joomla-cms/archive/staging.zip


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar AnneKlapwijk AnneKlapwijk - test_item - 15 Apr 2016 - Tested successfully
avatar AnneKlapwijk
AnneKlapwijk - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on c7a4be4

To test this I used this install package (thanks @brianteeman for the helpful comments).

I was able to:

  • install an extension by uploading a zip file
  • install an extension by URL
  • disable any tabs (Package File and URL or Path Folder)
  • order the 2 tabs (go to Extensions > Plugins, sort by column and drag the plugins in the desired order)
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.
avatar roland-d
roland-d - comment - 16 Apr 2016

@wnnz34 @Wolf-Rost Please update this PR so the conflicts are resolved.

avatar brianteeman brianteeman - change - 19 Apr 2016
Status Pending Needs Review
Labels
avatar brianteeman
brianteeman - comment - 19 Apr 2016

Setting to Needs Review so the CMS Maintainers can make a decision


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar roland-d
roland-d - comment - 19 Apr 2016

I have spoken to @Wolf-Rost he is going to fix this PR.

avatar joomla-cms-bot
joomla-cms-bot - comment - 21 Apr 2016

This PR has received new commits.

CC: @AnneKlapwijk, @bertmert, @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar joomla-cms-bot
joomla-cms-bot - comment - 21 Apr 2016

This PR has received new commits.

CC: @AnneKlapwijk, @bertmert, @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar brianteeman brianteeman - change - 27 Apr 2016
Category Administration Plugins Feature Request Administration Feature Request Language & Strings Plugins
avatar brianteeman brianteeman - change - 27 Apr 2016
Labels
avatar Kubik-Rubik Kubik-Rubik - test_item - 7 May 2016 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on c7a4be4

Thank you for the improvement!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar brianteeman brianteeman - change - 7 May 2016
Status Needs Review Ready to Commit
avatar brianteeman
brianteeman - comment - 7 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8201.

avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 7 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 7 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 7 May 2016
Milestone Removed:
avatar roland-d roland-d - change - 7 May 2016
Milestone Added:
avatar roland-d roland-d - change - 7 May 2016
Milestone Removed:
avatar roland-d roland-d - change - 7 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-07 14:18:31
Closed_By roland-d
avatar roland-d
roland-d - comment - 7 May 2016

Thank you everybody for your participation. PR has been merged.

avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment