? Success
Pull Request for # 8188

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
28 Oct 2015

Improvements in recaptcha 2.0 so that it uses HTML5 data-* atributes instead of jquery to load.

This makes it work even if the google javascript file execution is delayed to the javascript onload event.

Also the code has no inline js.

Test instructions

Ativate recaptcha 2.0 in the plugin settings and global settings.
Test "Forget your password" page or a "Contact form".
It should work ok.

BC: No problems that i know of. But i don't have a complete understanding of Joomla history, so i leave that to the people that have it.

Note: For testing the javascript execution after the onload event use an extension that allows doing that.

avatar andrepereiradasilva andrepereiradasilva - open - 28 Oct 2015
avatar andrepereiradasilva andrepereiradasilva - change - 28 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2015
Labels Added: ?
avatar roland-d
roland-d - comment - 28 Oct 2015

@andrepereiradasilva

Note: For testing the javascript execution after the onload event use an extension that allows doing that.

Do you have an example of such extension?

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Oct 2015

@roland-d I think jbetolo allows it.

avatar roland-d
roland-d - comment - 28 Oct 2015

@andrepereiradasilva I see thet jbetolo is a compressor sort of speak. Perhaps I misunderstand your comment.

Note: For testing the javascript execution after the onload event use an extension that allows doing that.

Could you perhaps explain this in more detail in how it is related to the test?

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Oct 2015

jbetolo is performance tool. Allows you to compress js/css files and also, in the case of javascript, it allows you to "Defer" the javascript processing to the page onload event.

Instead of being executed when the browser is reading the page and waiting for the script to be downloaded and processed to continue rendering the page, if you defer the script execution to the page onload event, the page is rendered much faster by the browser.

The current recaptcha plugin doesn't work if you defer the javascript execution to after the page onload event. See #8188. So this PR solves that issue.

I didn't try with jbetolo because i use a custom plugin for defereing the javascript to the page onload event (and it works fine in that plugin). But i can try tomorrow using jbetolo or some other extension that can do that.

avatar Fedik
Fedik - comment - 29 Oct 2015

finally someone made it :smile:
looks good, later I try check/test the code

avatar zero-24 zero-24 - change - 29 Oct 2015
Category Plugins
avatar zero-24 zero-24 - change - 29 Oct 2015
Rel_Number 0 8188
Relation Type Pull Request for
avatar Fedik Fedik - test_item - 29 Oct 2015 - Tested successfully
avatar Fedik
Fedik - comment - 29 Oct 2015

I have tested this item :white_check_mark: successfully on 17bfad6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8191.

avatar andrepereiradasilva
andrepereiradasilva - comment - 29 Oct 2015

Tested with two system plugins and now it loads the captcha. If you use the old code if doesn't load.

ScriptMerge

Plugin Options changes:

Merge Options Tab

Merge JS: Yes
Enable in frontend: Yes
Rest of options: No

Loading Options Tab

Defer Merged File: Any of the options
Merged JS position: Any of the options

jbetolo

Plugin Options changes:

Javascript Tab

Defer: script(onload event)

avatar n9iels n9iels - test_item - 1 Nov 2015 - Tested successfully
avatar n9iels
n9iels - comment - 1 Nov 2015

I have tested this item :white_check_mark: successfully on 0f56054

Tested with jbetolo, before reCaptcha is not visible after applying the patch no problems :+1:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8191.

avatar zero-24 zero-24 - alter_testresult - 1 Nov 2015 - Fedik: Tested successfully
avatar zero-24 zero-24 - change - 1 Nov 2015
Milestone Added:
avatar zero-24 zero-24 - change - 1 Nov 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 1 Nov 2015

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8191.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2015
Labels Added: ?
avatar roland-d roland-d - reference | 5366162 - 2 Nov 15
avatar roland-d roland-d - merge - 2 Nov 2015
avatar roland-d roland-d - close - 2 Nov 2015
avatar roland-d roland-d - change - 2 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-02 07:22:53
Closed_By roland-d
avatar roland-d roland-d - close - 2 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 2 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2015
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 14 Nov 2015

Add a Comment

Login with GitHub to post a comment