User tests: Successful: Unsuccessful:
Improvements in recaptcha 2.0 so that it uses HTML5 data-* atributes instead of jquery to load.
This makes it work even if the google javascript file execution is delayed to the javascript onload event.
Also the code has no inline js.
Ativate recaptcha 2.0 in the plugin settings and global settings.
Test "Forget your password" page or a "Contact form".
It should work ok.
BC: No problems that i know of. But i don't have a complete understanding of Joomla history, so i leave that to the people that have it.
Note: For testing the javascript execution after the onload event use an extension that allows doing that.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
@andrepereiradasilva I see thet jbetolo is a compressor sort of speak. Perhaps I misunderstand your comment.
Note: For testing the javascript execution after the onload event use an extension that allows doing that.
Could you perhaps explain this in more detail in how it is related to the test?
jbetolo is performance tool. Allows you to compress js/css files and also, in the case of javascript, it allows you to "Defer" the javascript processing to the page onload event.
Instead of being executed when the browser is reading the page and waiting for the script to be downloaded and processed to continue rendering the page, if you defer the script execution to the page onload event, the page is rendered much faster by the browser.
The current recaptcha plugin doesn't work if you defer the javascript execution to after the page onload event. See #8188. So this PR solves that issue.
I didn't try with jbetolo because i use a custom plugin for defereing the javascript to the page onload event (and it works fine in that plugin). But i can try tomorrow using jbetolo or some other extension that can do that.
finally someone made it
looks good, later I try check/test the code
Category | ⇒ | Plugins |
Rel_Number | 0 | ⇒ | 8188 |
Relation Type | ⇒ | Pull Request for |
I have tested this item successfully on 17bfad6
Tested with two system plugins and now it loads the captcha. If you use the old code if doesn't load.
Plugin Options changes:
Merge JS: Yes
Enable in frontend: Yes
Rest of options: No
Defer Merged File: Any of the options
Merged JS position: Any of the options
Plugin Options changes:
Defer: script(onload event)
I have tested this item successfully on 0f56054
Tested with jbetolo, before reCaptcha is not visible after applying the patch no problems
Milestone |
Added: |
Milestone |
Added: |
||
Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-02 07:22:53 |
Closed_By | ⇒ | roland-d |
Labels |
Removed:
?
|
@andrepereiradasilva
Do you have an example of such extension?