? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
28 Oct 2015

This is something to discuss.
When language packs are created, they need to include a package manifest file. This file is documented on https://docs.joomla.org/J3.x:Making_a_Language_Pack_for_Joomla.
Since the english language is already installed, and can't be uninstalled, there is no need for such a manifest file withing core. That's why it is missing.
However when translating using Crowdin (or similar tools), that file has to be present as otherwise it can't be translated.

I would love to have the "example" package manifest file within core, so changes could be done here and synced with Crowdin automatically.

Just adding the package doesn't seem to generate any side effects. I wasn't able to discover it or uninstall the language from withing the extension manager.

This PR just adds a package manifest file for en-GB.
It also contains the version numbering scheme that is expected to be used by translations.
It also contains a link to Crowdin, again doesn't really matter what we put in there as it's just an example for translators. For Crowdin, there just needs to be something written in it.

@horus68 @infograf768 @imanickam What do you think?

avatar Bakual Bakual - open - 28 Oct 2015
avatar Bakual Bakual - change - 28 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 28 Oct 2015

Version: should be 3.5 (Although we know it does not matter)

<extension type="package" version="3.5" method="upgrade">

avatar infograf768
infograf768 - comment - 28 Oct 2015

Also, I do not see the use for the crowdin link as it may only confuse TTs (ancient and new)

avatar Bakual
Bakual - comment - 28 Oct 2015

I just filled in something so it can be translated. What do translators usually fill in there? The docs page has those elements empty :)

avatar horus68
horus68 - comment - 28 Oct 2015

Ok from me for the file.
And.. no empty tags, please!

avatar zero-24 zero-24 - change - 29 Oct 2015
Category Language & Strings
avatar imanickam
imanickam - comment - 29 Oct 2015

It is a good idea to show a sample for future translators.

I would not suggest having the crowdin information in the tag .... The reason being it has not become an Joomla's official translation tool yet. I would suggest having the url http://community.joomla.org/translations

avatar Bakual
Bakual - comment - 29 Oct 2015

Already changed the link to the GitHub repo. I think that makes most sense as it's the place the strings actually live.

avatar infograf768 infograf768 - test_item - 31 Oct 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 31 Oct 2015

I have tested this item :white_check_mark: successfully on 6f4fd5a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8183.

avatar AlejandroPascoli AlejandroPascoli - test_item - 6 Nov 2015 - Tested successfully
avatar AlejandroPascoli
AlejandroPascoli - comment - 6 Nov 2015

I have tested this item :white_check_mark: successfully on 6f4fd5a

Installed patch. found new manifest file in the manifest folder. Tested Succesfully.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8183.

avatar anibalsanchez anibalsanchez - test_item - 6 Nov 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 6 Nov 2015

I have tested this item :white_check_mark: successfully on 6f4fd5a

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8183.

avatar zero-24 zero-24 - change - 6 Nov 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24 zero-24 - change - 6 Nov 2015
Milestone Added:
avatar zero-24
zero-24 - comment - 6 Nov 2015

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8183.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 6 Nov 2015

Thank you @Bakual and testers! Merged.

avatar Kubik-Rubik Kubik-Rubik - close - 6 Nov 2015
avatar Kubik-Rubik Kubik-Rubik - reference | 9bfc7e6 - 6 Nov 15
avatar joomla-cms-bot joomla-cms-bot - close - 6 Nov 2015
avatar Kubik-Rubik Kubik-Rubik - merge - 6 Nov 2015
avatar Kubik-Rubik Kubik-Rubik - close - 6 Nov 2015
avatar Kubik-Rubik Kubik-Rubik - change - 6 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-06 22:26:34
Closed_By Kubik-Rubik
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2015
Labels Removed: ?
avatar Bakual Bakual - head_ref_deleted - 7 Nov 2015

Add a Comment

Login with GitHub to post a comment