Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8170] - Changing the selector type to avoid inconsistency

? Success

User tests: Successful: Unsuccessful:

avatar MAT978
MAT978
26 Oct 2015

Steps to reproduce the issue

Go to the language filter plugin
In the backend, go to:
Extensions->Plugins->System - Language Filter

Actual result

The selector for the "Cookie Lifetime" (Year/Session) is a radio btn type with:
class="btn-group btn-group-yesno" then 'success' (green) for "Year" and 'danger' (red) for "Session"
before

Expected result

As it is not a kind of yes/no selector and to be consistent, I think we should use a type="list" instead of the type="radio"
after

avatar MAT978 MAT978 - open - 26 Oct 2015
avatar MAT978 MAT978 - change - 26 Oct 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - test_item - 27 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 27 Oct 2015

I have tested this item :white_check_mark: successfully on d339834

Works and looks better. Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8170.

avatar zero-24 zero-24 - change - 27 Oct 2015
Category ⇒ Administration UI/UX
avatar zero-24 zero-24 - change - 27 Oct 2015
Easy No ⇒ Yes
avatar bertmert
bertmert - comment - 27 Oct 2015

@test Tested successfully :white_check_mark:

avatar zero-24 zero-24 - alter_testresult - 27 Oct 2015 - bertmert: Tested successfully
avatar zero-24 zero-24 - change - 27 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 27 Oct 2015
Milestone Added:
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 27 Oct 2015

RTC for 3.4.6 Thanks @MAT978 and @bertmert :smiley:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8170.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - reference | 06be0a2 - 27 Oct 15
avatar rdeutz rdeutz - merge - 27 Oct 2015
avatar rdeutz rdeutz - close - 27 Oct 2015
avatar rdeutz rdeutz - close - 27 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 27 Oct 2015
avatar rdeutz rdeutz - change - 27 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-27 21:00:43
Closed_By ⇒ rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment