[#8166] - Ensure we have a instance of JApplicationCms
- Fixed in Code Base
- 9 Dec 2016
- Medium
- Build: staging
- Easy Test
- # 8166
- Diff
- wilsonge:juser-cli
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This allows the creation of users via CLI scripts that currently error because the application object is an instance of JApplicationCli and the isAdmin method doesn't exist.
You can test by ensuring that creating a user in the frontend and backend of Joomla work as expected. If you want to have bonus brownie points you can create your own CLI script that will now create users succesfully
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I mean the configuration you can actually deal with if you custom code things
$instance = JApplicationCli::getInstance('MyScript');
$instance->loadConfiguration(JFactory::getConfig());
JFactory::$application = $instance;
$instance->execute();Actually what fails is 'enqueueMessage' :p
Actually the command runner still should be running the afterSave plugin event so unless I'm missing something this is still an issue for it?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8166.
It helps with defining a standard interface, something we're lacking for the CMS application class because we basically assume everywhere in the code that apps will always be a web application based on our CMS application class.
zero-24
- | Category | ⇒ | Libraries |
| Easy | No | ⇒ | Yes |
| Category | Libraries | ⇒ | Plugins |
@wilsonge Can you give an update on this PR?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8166.
brianteeman
- | Status | Pending | ⇒ | Information Required |
| Category | Plugins | ⇒ | Plugins Front End |
| Status | Information Required | ⇒ | Pending |
I have tested this item
After applying the patch creating users in the frontend and backend is still working.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8166.
I have tested this item
tested successfully - but without bonus brownie points... no clue how to do that ;)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8166.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Removed:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8166.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-09 22:26:07 |
| Closed_By | ⇒ | rdeutz |
cpfeifer
-
The only negative thing to this is it disables the ability to send e-mails to the new users when creating the accounts via CLI. Then again, everything inside this if statement assumes a JApplicationCms object is in use (i.e. getting the configuration data). There's no good answer here; you either hardcode a block for a feature or you start refactoring to make the code work on CLI correctly or impose new requirements on CLI apps (which BTW could be partially addressed with my command runner PR).