Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8164] - Don't load tags layouts unless there are tags (Part 2)

? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
26 Oct 2015

Same as #3275 but for remaining cases.

The affected layouts are:

  • Single Contact page in Protostar and Beez
  • Single Article page in Beez

Testing:
Make sure tags are shown when there are some assigned. You should actually see no change.
Testing instructions from PR 3275 can be used as well:

  1. Test the tags layout is shown in the frontend by viewing an article without tags. Adding a die; at the top of the layout (https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/content/tags.php) should kill your page.

APPLY PR

  1. Check your article without tags. The page should load happily now because the JLayout isn't being loaded.
  2. Check an article with tags and ensure the tags still show as expected in the frontend (don't forget to remove the die)
avatar Bakual Bakual - open - 26 Oct 2015
avatar Bakual Bakual - change - 26 Oct 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 27 Oct 2015
Category ⇒ Components Front End Templates (site)
avatar zero-24 zero-24 - change - 27 Oct 2015
Easy No ⇒ Yes
avatar brianteeman brianteeman - test_item - 13 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Apr 2016

I have tested this item :white_check_mark: successfully on e00cb89

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8164.

avatar waader waader - test_item - 15 Apr 2016 - Tested successfully
avatar waader
waader - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on e00cb89

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8164.

avatar brianteeman brianteeman - change - 15 Apr 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 15 Apr 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8164.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 15 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 15 Apr 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-15 12:13:14
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 15 Apr 2016
avatar rdeutz rdeutz - reference | a855fff - 15 Apr 16
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Removed: ?
avatar webmiep webmiep - test_item - 15 Apr 2016 - Tested successfully
avatar webmiep
webmiep - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on e00cb89

I tested this succesfully on 15-04-2016

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8164.

avatar Bakual Bakual - head_ref_deleted - 15 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment