Feeling Lucky
?
[#8156] - Code review on com_finder component
- Closed
- 30 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 8156
- Diff
- mbabker:review-finder-component
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR is a general overview and cleanup of some code structure and doc blocks in the admin com_finder component. Changes of note:
- Doc blocks cleaned up some to follow standard
- Return the results of the view's
display()methods to be consistent with the documented return - Not using variables for items only referenced once
- Use
Joomla\Utilities\ArrayHelperinstead ofJArrayHelper - Removed
static $logfrom methods instantiating a logger;JLog::addLogger()has no return value so the variable cannot be populated with data - Use of the
JApplicationWebAPI in the indexer for building and sending the application response - Support late static bindings in the indexer API classes, reference private members as
self:: - Renamed private members with a leading underscore for code style compliance
Testing Instructions
The admin com_finder component should continue to function correctly
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Administration |
| Easy | No | ⇒ | Yes |
wilsonge
- comment
- 26 Oct 2015
Otherwise looks good. Just due to the shear number of changes I want an actual practical test of this though just to be safe before merging
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-30 18:00:46 |
| Closed_By | ⇒ | mbabker |
Com_finder main controller has a random letter a on line 21