Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8154] - Code review on com_contact component

? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
25 Oct 2015

This PR is a general overview and cleanup of some code structure and doc blocks in the admin com_contact component. Changes of note:

  • Doc blocks cleaned up some to follow standard
  • Return the results of the view's display() methods to be consistent with the documented return
  • Not using variables for items only referenced once
  • Use Joomla\Utilities\ArrayHelper instead of JArrayHelper
  • Removed empty override methods (the parent class' method is also empty)

Testing Instructions

The admin com_contact component should continue to function correctly

avatar mbabker mbabker - open - 25 Oct 2015
avatar mbabker mbabker - change - 25 Oct 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 25 Oct 2015
Category ⇒ Administration
avatar zero-24 zero-24 - change - 25 Oct 2015
Easy No ⇒ Yes
avatar wilsonge
wilsonge - comment - 26 Oct 2015

Merged on review

avatar wilsonge wilsonge - change - 26 Oct 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-26 04:30:57
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 26 Oct 2015
avatar wilsonge wilsonge - reference | 5fb8c73 - 26 Oct 15
avatar wilsonge wilsonge - merge - 26 Oct 2015
avatar wilsonge wilsonge - close - 26 Oct 2015
avatar zero-24 zero-24 - change - 26 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment