? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
24 Oct 2015

jimport() is a proxy to JLoader::import() however the proxy does not support both method arguments that the real method does. This PR adds the second argument for jimport() to be able to pass it forward.

Testing Instructions

So I found this issue actually on a review of com_categories, but I'm not totally familiar with how the associations stuff works. Essentially though this line shouldn't actually import the right object in the current code since the second argument never gets forwarded so the right lookup path is never used. So if you can figure that out, you might actually validate a potential bug fix along the way. If you're lazy like I am though, you'll just read the code to validate the changes.

avatar mbabker mbabker - open - 24 Oct 2015
avatar mbabker mbabker - change - 24 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 24 Oct 2015
Category Libraries
avatar zero-24 zero-24 - change - 24 Oct 2015
Easy No Yes
avatar zero-24 zero-24 - change - 27 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 27 Oct 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 27 Oct 2015

RTC on code review. Thanks makes sense.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8144.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 27 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-27 21:00:08
Closed_By rdeutz
avatar rdeutz rdeutz - close - 27 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 27 Oct 2015
avatar rdeutz rdeutz - reference | de8a00f - 27 Oct 15
avatar rdeutz rdeutz - merge - 27 Oct 2015
avatar rdeutz rdeutz - close - 27 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Labels Removed: ?
avatar mbabker mbabker - head_ref_deleted - 27 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment