I have tested this item successfully on 9a763fb

@roland-d I think that JHtmlSidebar::setAction can be removed.
I've removed the clearfix in all three list views.

I applied the patch before activating the content plugin. The message that tells me that is now very close to the search filters. Maybe we can add some padding there?

I also noticed that the filter on "Content maps" are always visible, and for some reason the filter on the right is always marked as an active filter (There are blue lines around it).
On other places where we use this filters (com_content for example) the blue line only appears when we choose an option of the filter.

This PR has received new commits.

CC: @jduerscheid

Thanks @n9iels, I corrected the Branch filter on "Content maps".
Now it is not activated automatically anymore.

btw: I did not change the padding of the warning message...

Yes, that works for me! I see now the same problem appears for "indexed content", the search filter "Select type of content" is always active over there.

Also the search filter on "Content mapping" are always visible on that page. Or is that done by a certain reason?

About that padding and the message. Strange enough the message appears below the search filters. Other messages like "save" and "delete" appear above the messages.

Seems like all other message than "successfully saved", "successfully deleted" etc. appear below the filters. Not a problem for this PR I think so.
I will make a PR for that (after this PR and others are merged, otherwise that merge conflicts never solves )

Thanks for testing!

No, I did not set the filter to "always active" on purpose. I'll check if I can correct it.

If someone knows the cause of the problem, please correct it with a PR,
or tell me what to change & I'll do so...

@pe7er The "always active" happens because you have set a default value of 0 here: https://github.com/joomla/joomla-cms/pull/8140/files#diff-762a4c09ff9b1a26880f1391232575c2R23

The first option you give to the dropdown has a value of 0:
https://github.com/joomla/joomla-cms/pull/8140/files#diff-762a4c09ff9b1a26880f1391232575c2R29

that is why the first entry becomes an active one. I guess you can drop the default value setting.

This PR has received new commits.

CC: @jduerscheid

This PR has received new commits.

CC: @jduerscheid

@pe7er Travis cry

FILE: ...d/joomla/joomla-cms/administrator/components/com_finder/models/maps.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 176 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
     |       | (...)\n...{...}\n...else"
 184 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found "if
     |       | (...)\n...{...}...else"
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

I don't think the last change is correct. In Joomla 3.4.5 the dropdown looks like this:

Branches only as first option and I think we should keep that.

This PR has received new commits.

CC: @jduerscheid

I removed my previous PR "fixed Select Branch dropdown in Smart Search Content Maps"

I have tested this item successfully on 26670dd

Works as described. Thank you @pe7er!

Works but a small design problem:

This can also be fixed after we've merged this PR!

I have tested this item successfully on 26670dd

To solve the problem Victor mentioned above just move the filters under the message
like this:

        <?php if (!$this->pluginState['plg_content_finder']->enabled) : ?>
            <div class="alert fade in">
                <button class="close" data-dismiss="alert">×</button>
                <?php echo JText::_('COM_FINDER_INDEX_PLUGIN_CONTENT_NOT_ENABLED'); ?>
            </div>
        <?php endif; ?>
        <?php echo JLayoutHelper::render('joomla.searchtools.default', array('view' => $this)); ?>

I spotted that design problem too. Maybe it is an idea to move that message to a JFactory::getApplication()->enqueueMessage There are more component with that problem, where the search filters will be add.

Can make a PR for that components, when this PR is merged (to prevent merge conflicts)

RTC lets merge here and @n9iels or @dgt41 can send a fix for the design problem. Thanks

The branches dropdown needs to be checked. It is quite different from the current implementation.

Ah sorry overread this comment ;)

Looks good to me:

@dgt41 Compare it to the implementation in J3.4.5, it is quite different. The current implementation uses it's own JHtml class, that is completely skipped now.

ahh yeah, the finder way ????

This PR has received new commits.

CC: @dgt41, @jduerscheid, @Kubik-Rubik

I've removed the hardcoded SQL
query="SELECT id AS value, title AS branch FROM #__finder_taxonomy WHERE parent_id = 1"
from /administrator/components/com_finder/models/forms/filter_maps.xml and
added /administrator/components/com_finder/models/fields/branches.php
to retrieve the branches.

@pe7er I am afraid that administrator/components/com_finder/models/fields/branches.php doesn;t cover all the functionality of the old JHtml class https://github.com/joomla/joomla-cms/blob/staging/components/com_finder/helpers/html/filter.php#L208-L394

This PR has received new commits.

CC: @dgt41, @jduerscheid, @Kubik-Rubik

Removed the SQL query from fields/branches.php & replaced with return JHtml::_('finder.mapslist');
Thanks for the tip @roland-d !

@pe7er can you also implement this #8140 (comment)
so I can re-test this?

File administrator/components/com_finder/views/index/tmpl/default.php

@dgt41 yes, please!
I think that we should correct the layout issue with the message later because it might need to be corrected at other places as well...

Works fine here, one small UX tho:

Small issue:

Before:

After patch:

I don´t know if this regards this PR but if i don´t have published filters there is a message that "No filters have been created yet. Create a filter." - that´s not true because there are filters but they are unpublished.

Thanks for testing @dgt41 & @designbengel !
Those UX issues need to be corrected, but I think that it could be done for beta2 in another PR.

There is a Message that no content has been indexed by filtering unpublished items?

@designbengel I think this is an existing issue, this PR only moves the buttons from the sidebur to the Search Tools bar. Perhaps raise a separate issue for that?

I have tested this item successfully on b14cbd4

Ok, so like @roland-d says it´s regarding just the location-change of filters - so test for this is ok :)

Folks, I can't see
COM_FINDER_MAPS_SELECT_BRANCHE="- Select Branch -"
anywhere.

@pe7er @roland-d

I have the feeling some new lang strings were merged here that should'nt have...

@pe7er @roland-d Please test
#8558