? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
23 Oct 2015

The problem:

With the code from the 3.5-dev repo try to edit an article. Also try to insert an image with the new button in tinyMCE’s toolbar. Everything works as expected. Now try to change tab to Images and links and try to change the intro or the full text image. The modal will not close, the functionality is broken.

The solution:

Trying to redefine the jModalClose function (javascript) is not the best way to solve this. It’s far better to tackle this in the initial declaration of the function: in the file behavior.php

Testing:

Try to repeat the steps described above. Everything should work without any errors.

@roland-d Sorry for this mess, I just found this testing something different.

fcf55f7 23 Oct 2015 avatar dgt41 fix
avatar dgt41 dgt41 - open - 23 Oct 2015
avatar dgt41 dgt41 - change - 23 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 23 Oct 2015
Easy No Yes
avatar zero-24 zero-24 - change - 23 Oct 2015
Category Plugins
avatar roland-d roland-d - test_item - 23 Oct 2015 - Tested successfully
avatar roland-d
roland-d - comment - 23 Oct 2015

I have tested this item :white_check_mark: successfully on fcf55f7

Following the steps of adding an image to the article using the tinyMce toolbar button and then try to add an intro or full text image it fails. After applying the patch, everything works as expected again.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8133.

avatar Kubik-Rubik Kubik-Rubik - change - 24 Oct 2015
Milestone Added:
avatar designbengel
designbengel - comment - 24 Oct 2015

i don´t have any issue in 3.5-dev before applying the patch (chrome)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8133.

avatar roland-d
roland-d - comment - 25 Oct 2015

@designbengel Did you follow the steps? It only happens if you do those exact steps and then try to insert an image with the modal popup on the intro or full text image. The modal doesn't close.

avatar designbengel designbengel - test_item - 27 Oct 2015 - Tested successfully
avatar designbengel
designbengel - comment - 27 Oct 2015

I have tested this item :white_check_mark: successfully on fcf55f7

Sorry didn´t recognize that the modal does not close because i either clicked outside the modal or the close button (habit) :smile: Now i confirm behaviour and fix.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8133.

avatar zero-24 zero-24 - change - 27 Oct 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 27 Oct 2015

RTC for 3.5.0 :smiley: Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8133.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Labels Added: ?
avatar roland-d roland-d - change - 27 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-27 13:55:30
Closed_By roland-d
avatar roland-d roland-d - close - 27 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 27 Oct 2015
avatar roland-d roland-d - reference | fa4665c - 27 Oct 15
avatar roland-d roland-d - merge - 27 Oct 2015
avatar roland-d roland-d - close - 27 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2015
Labels Removed: ?
avatar dgt41 dgt41 - head_ref_deleted - 27 Oct 2015

Add a Comment

Login with GitHub to post a comment