Feeling Lucky
?
[#8131] - Hide sql error messages without debug enabled (frontend)
- Closed
- 23 Oct 2015
- Medium
- Build: staging
- # 8131
- Diff
- zero-24:HideSQLErrorMessagesWithoutDebugEnabled
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR hide the Error Message if the debug is disabled.
How to test
- produce any error message in the frontend
- see the error message
- apply this patch
- produce any error message in the frontend
- see that the error message is gone
- enable debug
- see the message comming back
Why this not replace #8129
This only works for templates that use the system layout as well as the default templates.
Question
Do we need the same for the backend? Or can we say "if you are in the backend you can do more things than detect the Table prefix"?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-23 14:14:39 |
| Closed_By | ⇒ | zero-24 |
So just for reference, this isn't just SQL error messages. Rather, this PR changes the behavior so that all Exception object messages will no longer be displayed on the error pages. This would need to be tested with other scenarios, i.e. any place we're still using JError to redirect to the error page, to ensure that when the user hits the error page they still end up with something useful.
From a pure code perspective, this is really just a bandaid over a bullet hole. Our overall error handling is complete garbage, PRs like this aren't doing anything to address the real issue of the lack of internal error handling within the various pieces of the overall application.