User tests: Successful: Unsuccessful:
Solved issue from #7352
The issue:
When a user enters an internal link into the field link a, b or c on the tab images and links of the edit content page and presses save, an unexpected result will show up. Instead of an internal link of the same page, he gets a modified link, that links to the root of the Joomla instance. For instance, let's assume that the user enters #title . This will be modified to /#title. Or - if joomla is installed in an subfolder - it will be modifed to /subfolder/#title.
How to test:
2. Go to Content > Content Manager
3. Open a random content item
4. Go to tab "Images and Links"
5. Enter "#to-some-position-on-page" in field "Link A"
6. Click button "Save"
7. Go back to "Images and Links"
With the unsolved issue:
See that the content of field "Link A" has changed from "#to-some-position-on-page" to "/#to-some-position-on-page
After the Pull Request
See that the content of field "Link A" hasn’t changed. It’s shows still the internal link.
The solution:
To solve this issue, one has to distinguish between a usual link to another page and an internal link. For this reason I check with a regex pattern, if the entry is a valid internal link. If this is true, the link will not be modified. If the pattern doesn't match, the link is passed by the normal way.
The file is located at ./administrator/components/com_content/models/article.php.
Worked as a group on that issue: @icampus, @FPerisa, @flow87 and @kathastaden
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Title |
|
Category | ⇒ | Administration |
Easy | No | ⇒ | Yes |
I have tested this item successfully on b64348f
Works as described. Without the patch, the whole path is added in front of the #-sign
Status | Pending | ⇒ | Ready to Commit |
Thank you for your Tests and collaboration @Zero-24, @koolman01 and @balzercomp.
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-25 10:27:54 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
Don't we add an empty line before a foreach
?
@infograf768 We should according to codestyle.
Done here: #8151 @infograf768 and @roland-d
Can you RTC / merge?
Milestone |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
I have tested this item successfully on b64348f
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8125.