? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
17 Oct 2015

Issue

With #7654 the menu manager now shows the view title if that title is specified and translated.
The only place in core this is the case is for the wrapper menuitem. For the wrapper, it's quite useless as it's just duplicated information. It looks like this:
wrapper

Solution

This PR completely removes the metadata.xml as it is optional after the previous PR (the title was required, alltough never used).
Since we don't want to show the view title and don't specify any parameters for the view (they are specified at the layout level), we can safely remove the whole file.

Testing

  • Create a menu item for the Wrapper
  • See that it shows as Wrapper » Wrapper » Iframe Wrapper in the menu manager
  • Apply PR and check again, it shows now as Wrapper » Iframe Wrapper: wrapper2

There should be no side effects other than that.

avatar Bakual Bakual - open - 17 Oct 2015
avatar Bakual Bakual - change - 17 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2015
Labels Added: ?
avatar Bakual Bakual - change - 17 Oct 2015
The description was changed
avatar zero-24 zero-24 - change - 17 Oct 2015
Easy No Yes
avatar zero-24 zero-24 - change - 17 Oct 2015
Category Administration UI/UX
avatar MAT978 MAT978 - test_item - 17 Oct 2015 - Tested successfully
avatar MAT978
MAT978 - comment - 17 Oct 2015

I have tested this item :white_check_mark: successfully on 710aed7

able to reproduce then #7654 works as described - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8108.

avatar zero-24 zero-24 - test_item - 17 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 17 Oct 2015

I have tested this item :white_check_mark: successfully on 710aed7

Works using last staging and this PR here. Thabks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8108.

avatar zero-24 zero-24 - change - 17 Oct 2015
Milestone Added:
avatar zero-24
zero-24 - comment - 17 Oct 2015

RTC. Thanks :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8108.

avatar zero-24 zero-24 - change - 17 Oct 2015
Milestone Added:
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - close - 19 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 19 Oct 2015
avatar rdeutz rdeutz - reference | f3109a6 - 19 Oct 15
avatar rdeutz rdeutz - merge - 19 Oct 2015
avatar rdeutz rdeutz - close - 19 Oct 2015
avatar rdeutz rdeutz - change - 19 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-19 07:32:22
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2015
Labels Removed: ?
avatar Bakual Bakual - head_ref_deleted - 19 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment