Closed
22 Aug 2016
Medium
Build: staging
Easy Test
# 8106
Diff
Mathewlenning:Issue-5820

Failure

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Failure JTracker/HumanTestResults Human Test Results: 0 Successful 3 Failed. Details

Pull Request for # 5820

User tests: Successful: Unsuccessful:

Mathewlenning
17 Oct 2015

This resolve an issue with TinyMCE and the use of width and height on JForm editor field element.

How to test

Before applying the patch try to resize the TinyMCE editor via a JForm xml field definition. Add width and height attributes to the editor definition in the xml file

        <field
                name="default_description"
                type="editor"
                buttons="true"
                label="CONTENT_TEXT_LABEL"
                description="CONTENT_TEXT_DESC"
                class="inputbox"
                filter="JComponentHelper::filterText"
                asset_id="com_content"
                width="50%"
                height="200px"
                />

then open the form to confirm that the editor width/height has not changed.

After applying the patch confirm that the width and height do change.

46bbf41 17 Oct 2015

Resolves Issue #5820

Mathewlenning - open - 17 Oct 2015

Mathewlenning - change - 17 Oct 2015

Status

New

⇒

Pending

joomla-cms-bot - change - 17 Oct 2015

Labels

Added: ?

zero-24 - change - 17 Oct 2015

Category

⇒

Libraries

zero-24 - change - 17 Oct 2015

Rel_Number	0	⇒	5820
Relation Type		⇒	Pull Request for
Easy	No	⇒	Yes

PhocaCz - test_item - 24 Oct 2015 - Tested unsuccessfully

PhocaCz - comment - 24 Oct 2015

I have tested this item unsuccessfully on 46bbf41

Hi, tested now but I get still the problem.

Changed the XML of administrator\components\com_content\models\forms\article.xml (before and after patch) but nothing changed. :-(

Testing % or px but no change for me.

Jan

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

PhocaCz - test_item - 24 Oct 2015 - Tested unsuccessfully

matrikular - test_item - 24 Oct 2015 - Tested unsuccessfully

matrikular - comment - 24 Oct 2015

I have tested this item unsuccessfully on 46bbf41

Tested with administrator\components\com_content\models\forms\article.xml without changes in behavior.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

designbengel - test_item - 24 Oct 2015 - Tested unsuccessfully

designbengel - comment - 24 Oct 2015

I have tested this item unsuccessfully on 46bbf41

Added a new field and it also didn´t work

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

Mathewlenning - comment - 24 Oct 2015

I think the reason it isn't working has something to do with the session, I'll put some work on it Monday evening.

Also since it is a change to the JS, might have to clear the cache.

I'll post more when I find the issue.

Sincerely,
Mathew Lenning

P.S. This message was sent via iPhone, so please forgive any errors

On Oct 24, 2015, at 7:46 PM, designbengel notifications@github.com wrote:

I have tested this item unsuccessfully on 46bbf41

Added a new field and it also didn´t work

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.
―
Reply to this email directly or view it on GitHub.

studio42 - comment - 31 Oct 2015

The problem is not here.
The code is same as in Joomla2.5 and this worked perfectly in Joomla 2.5.
I think the problem is in the plugin

mbabker - comment - 23 Jun 2016

Is this going anywhere? I just wasted 15 minutes fighting with this same issue today before remembering there've been several long standing reports on this exact thing.

roland-d - comment - 23 Jun 2016

@mbabker Is the solution provided here working for you? As I see there were 3 unsuccessful tests in the past. I can take this to the PBF this Saturday.

mbabker - comment - 23 Jun 2016

I didn't test it given the unsuccessful tests and the comment that the submitter would follow up on things.

roland-d - comment - 23 Jun 2016

I figured as much, was just wondering if you used the same code to fix it in your case.

brianteeman - comment - 23 Jun 2016

Exceedingly unlikely that this submitter will do anything

On 23 June 2016 at 15:39, Michael Babker notifications@github.com wrote:

I didn't test it given the unsuccessful tests and the comment the
submitter would follow up on things.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8106 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8WAk_DpzKDm_H8mUN70227_R3yNgks5qOpq-gaJpZM4GQqx5
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

studio42 - comment - 26 Jun 2016

HI all, i don't have checked, if it work, but why it not work.
Current \plugins\editors\tinymce\tinymce.php do not check for width but html_width XML parameter. So i think changing width in XML do not resolve anything.(this only change the textarea size).
If you check in this file line 916 (joomla 3.5.1)
width : \"$html_width\",
see https://www.tinymce.com/docs/configure/editor-appearance/#width for reference.

if "width" is empty, then editor is always full width and dont check for the text area size.
So i think the best solution, is to use a container and set the width in the container, so editor have right width and can use responsive(if needed).
Note, i don't have check on Joomla if this work, only played with tinyMCE on codepen
Try this : <div style="width:400px"><textarea><p>testing</p></textarea></div>
You can test on original tinymce codepen http://codepen.io/tinymce/pen/NGegZK and add the div tag too see it work.

conconnl - comment - 28 Jun 2016

@Mathewlenning @roland-d @mbabker
One of our PBF users in the Netherlands will look at this issue and come with a fix. (@DanielvanBavel)
#8591 can be closed to and this one can be referenced, when we find more from the same issue we will mention it.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

roland-d - comment - 29 Jun 2016

@conconnl Once @DanielvanBavel has created his PR, we can close this one.

roland-d - comment - 31 Jul 2016

@DanielvanBavel Did you create the new PR?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

brianteeman - comment - 3 Aug 2016

@roland-d is there a PR for this - cant see one

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

conconnl - comment - 3 Aug 2016

I have send him a message.
Hopefully he will respond today or tomorrow.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

DanielvanBavel - comment - 3 Aug 2016

@conconnl and @roland-d it already set the height of a textarea field if you set a height into the plugin height value. that was the problem right?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

roland-d - comment - 16 Aug 2016

@DanielvanBavel I just remember you found something where it was hardcoded I think. Wasn't the plan to make that overridable? If you can outline what the cause is we can see how to proceed.

DanielvanBavel - comment - 17 Aug 2016

Yeah i found something. The size was hardcoded. And after i deleted that code you can set the size in the plugin. So shall i create a PR @roland-d ?

conconnl - comment - 17 Aug 2016

I think the problem was that the size was hard coded in the plugin and therefore the size definitions from the xml files in the different views did not work.
The question is do you want to keep the size settings configurable in the plugin or do you want to remove the default values.
When you remove the default values from the plugin I would expect the default values from the views would be used and only when you configure the value in he plugin you would override the view size definition.

roland-d - comment - 17 Aug 2016

We do need a pull request to fix this and see how and if we can keep backwards compatibility. I also wonder when it was changed because I assume when these options were implemented they worked :)

DanielvanBavel - comment - 18 Aug 2016

Like @conconnl said. There are hardcodes values i deleted them so you be able to set the values you want in the plugin. I trying to create a PR. But i'm not totally know how. So i will give it a try. @conconnl send me a few links yesterday.

brianteeman - comment - 22 Aug 2016

I am closing this at this time as we have a PR

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

brianteeman - change - 22 Aug 2016

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2016-08-22 19:52:23
Closed_By		⇒	brianteeman

brianteeman - close - 22 Aug 2016

DanielvanBavel - comment - 30 Aug 2016

@brianteeman you can open this issue. PR has been created.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}

brianteeman - comment - 30 Aug 2016

@DanielvanBavel thanks for creating the PR. No need to re-open this - your action of creating a PR created an issue on the tracker we dont need both

DanielvanBavel - comment - 31 Aug 2016

@briaanteeman yes i understand that. Thanks for you explantion!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8106.}