[#8102] - Add missing self-closing tag for input-tag within JHtmlSelect
- Closed
- 24 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 8102
- Diff
- hordijk:staging
- Pending Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The input-tag within the radiolist function of JHtmlSelect is not closed, causing issues in validators. This change fixes the issue and created a input-tag which is inline with the other HTML utility classes as well, which are already using self-closing tags.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
| Labels |
Removed:
?
|
||
| Easy | No | ⇒ | Yes |
So for testing it is just make sure the select options still work after the patch.
Please correct me if I wrong.
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8102.
| Labels | |||
I've updated the corresponding unit test as well. But you should test if the select options are still working. You can check for example the search component.
The file components/com_search/views/search/view.html.php contains:
$lists['searchphrase'] = JHtml::_('select.radiolist', $searchphrases, 'searchphrase', '', 'value', 'text', $state->get('match'));
If the search_phrases are shown in the front-end search the generated HTML was not valid due to the missing self-closing tag. You can use https://validator.w3.org/ to validate the generated HTML.
I have tested this item 
successfully on 403116d
The testinstructions are misleading. The validator only throws an validation error if an html4 template is used. In HTML5 self closing tags don't require the closing slash.
So, it would suggest to test this by checking the generated HTML with the inspection tools of your browser manually. That way I was able to test and verify that the patch is working.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8102.
I have tested this item successfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8102.
i have tested this item successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8102.
| Status | Pending | ⇒ | Ready to Commit |
3 successful tests, setting to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8102.
| Labels |
Added:
?
|
||
Kubik-Rubik
- | Milestone | |||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-24 13:07:06 |
| Closed_By | ⇒ | Kubik-Rubik |
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
wilsonge
- | Labels |
Removed:
?
|
||
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.